third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/resources/popup-ready-to-navigate-child.html - Issue 1374533002: Null out LocalDOMWindow::m_frame on navigation.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/frameNavigation/resources/popup-ready-to-navigate-child.html

Issue 1374533002: Null out LocalDOMWindow::m_frame on navigation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix tests and add a test Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/parser/resources/set-parent-to-javascript-url.html ('k') | third_party/WebKit/LayoutTests/http/tests/security/resources/xss-eval2.html » ('j') | third_party/WebKit/Source/core/frame/DOMWindow.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <script>	1 <script>

	2 var f = window.frames;

2 function go() {	3 function go() {

3 window.frames[0].location = "http://127.0.0.1:8000/security/frameNavigation/ resources/fail.html";	4 f[0].location = "http://127.0.0.1:8000/security/frameNavigation/resources/fa il.html";
	dcheng 2015/09/29 07:53:25 Incidentally... this test was actually failing whe Incidentally... this test was actually failing when run manually without my changes. +japhet... is there any DRT callback to dump out loading attempts? Alternatively, maybe using a JS URL to try to alert here would be good enough? Nate Chapin 2015/09/29 21:49:00 How was it failing? There's a DRT mode that will d Show quoted text On 2015/09/29 07:53:25, dcheng wrote: > Incidentally... this test was actually failing when run manually without my > changes. > > +japhet... is there any DRT callback to dump out loading attempts? > > Alternatively, maybe using a JS URL to try to alert here would be good enough? How was it failing? There's a DRT mode that will dump resource messages, but I don't see that in use for any users of this file. dcheng 2015/09/29 21:53:52 I believe this test is attempting to test that thi Show quoted text On 2015/09/29 at 21:49:00, Nate Chapin wrote: > On 2015/09/29 07:53:25, dcheng wrote: > > Incidentally... this test was actually failing when run manually without my > > changes. > > > > +japhet... is there any DRT callback to dump out loading attempts? > > > > Alternatively, maybe using a JS URL to try to alert here would be good enough? > > How was it failing? There's a DRT mode that will dump resource messages, but I don't see that in use for any users of this file. I believe this test is attempting to test that this navigation is blocked. Since there's no event to listen to in this circumstance, the test just completes and optimistically hopes that the navigation wasn't scheduled. However, if you ran it locally, it did navigate to fail.html and pop up an alert().
4 }	5 }

5 opener.postMessage("ready", "*");	6 opener.postMessage("ready", "*");

6 </script>	7 </script>

OLD	NEW