Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Issue 1374513002: Add missing app permissions to media stream examples (Closed)

Created:
5 years, 2 months ago by Sunny
Modified:
5 years, 2 months ago
Reviewers:
sbc, Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing app permissions to media stream examples For media_stream_audio example, add 'audioCapture' permission For media_stream_video example, add 'videoCapture' permission Missing these permissions will cause NavigatorUserMediaError BUG=NONE TEST=Build the app and load it into Chrome, you should see it's working. Committed: https://crrev.com/4c33b2d569d4ddeec03b1984c4d35659293d0a4f Cr-Commit-Position: refs/heads/master@{#351120}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M native_client_sdk/src/examples/api/media_stream_audio/example.dsc View 1 chunk +2 lines, -1 line 0 comments Download
M native_client_sdk/src/examples/api/media_stream_video/example.dsc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Sunny
Hi everyone, could you help to review this patch? Thanks.
5 years, 2 months ago (2015-09-27 09:24:36 UTC) #2
sbc
lgtm
5 years, 2 months ago (2015-09-28 17:13:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374513002/1
5 years, 2 months ago (2015-09-28 17:16:42 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 2 months ago (2015-09-28 17:16:44 UTC) #8
Sam Clegg
lgtm
5 years, 2 months ago (2015-09-28 17:18:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374513002/1
5 years, 2 months ago (2015-09-28 17:20:13 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 19:40:05 UTC) #12
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 19:40:48 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4c33b2d569d4ddeec03b1984c4d35659293d0a4f
Cr-Commit-Position: refs/heads/master@{#351120}

Powered by Google App Engine
This is Rietveld 408576698