Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1315)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1374463002: Remove support for "all or none" two-phase data pipe read/write. (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
rogulenko, jamesr
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove support for "all or none" two-phase data pipe read/write. (Will clean up/simplify the rest of mojo/edk/system separately.) BUG=#366 R=jamesr@chromium.org, rogulenko@google.com Committed: https://chromium.googlesource.com/external/mojo/+/8b1ba5723ad195b5207ac64a9289dc4a3cadfa40

Patch Set 1 #

Total comments: 1

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -97 lines) Patch
M examples/go/http_server.go View 2 chunks +7 lines, -7 lines 0 comments Download
M mojo/edk/system/core_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +6 lines, -2 lines 0 comments Download
M mojo/go/tests/system_test.go View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/public/c/system/data_pipe.h View 6 chunks +22 lines, -55 lines 0 comments Download
M mojo/public/go/bindings/invalid_handle.go View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/public/go/system/data_pipe.go View 6 chunks +10 lines, -15 lines 0 comments Download
M mojo/public/go/system/system.go View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/platform/native_cgo/system_cgo.go View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
viettrungluu
jamesr -> C/C++ changes, rogulenko -> Go changes
5 years, 2 months ago (2015-09-25 23:15:49 UTC) #1
jamesr
lgtm
5 years, 2 months ago (2015-09-25 23:20:28 UTC) #2
rogulenko
lgtm https://codereview.chromium.org/1374463002/diff/1/mojo/public/platform/native_cgo/system_cgo.go File mojo/public/platform/native_cgo/system_cgo.go (right): https://codereview.chromium.org/1374463002/diff/1/mojo/public/platform/native_cgo/system_cgo.go#newcode152 mojo/public/platform/native_cgo/system_cgo.go:152: var bufferNumBytes C.uint32_t indent with tabs
5 years, 2 months ago (2015-09-25 23:23:05 UTC) #3
viettrungluu
On 2015/09/25 23:23:05, rogulenko wrote: > lgtm > > https://codereview.chromium.org/1374463002/diff/1/mojo/public/platform/native_cgo/system_cgo.go > File mojo/public/platform/native_cgo/system_cgo.go (right): > ...
5 years, 2 months ago (2015-09-25 23:24:47 UTC) #4
viettrungluu
5 years, 2 months ago (2015-09-25 23:29:53 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8b1ba5723ad195b5207ac64a9289dc4a3cadfa40 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698