Issue 1374443002: Separate non-SFI NaCl from SFI NaCl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1374443002: Separate non-SFI NaCl from SFI NaCl. (Closed)

Created:
5 years, 2 months ago by Sean Klein

Modified:
5 years, 2 months ago

Reviewers:
Petr Hosek

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Separate non-SFI NaCl from SFI NaCl. BUG=https://github.com/domokit/mojo/issues/396 R=phosek@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/ba7a65621a7dda11f603ea4ee7c3cb01a6f9ff84

Patch Set 1 #

Patch Set 2 : Android not ready (yet) #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
	M	mojo/BUILD.gn	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
	M	mojo/nacl/BUILD.gn	View		2 chunks	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Sean Klein

5 years, 2 months ago (2015-09-25 21:43:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ba7a65621a7dda11f603ea4ee7c3cb01a6f9ff84 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages