Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 137443020: [Android WebView] Do not block GetOffscreenContextProviderForMainThread (Closed)

Created:
6 years, 11 months ago by boliu
Modified:
6 years, 11 months ago
Reviewers:
no sievers
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

[Android WebView] Do not block GetOffscreenContextProviderForMainThread Before this, we fail create a main thread shared context if there are no webviews in hardware initialized mode. The future plan is for accelerated 2d canvas and webgl to use a shared context with the gpu thread service, but keep inline video using the ui thread service. Currently only video uses main thread context for webview, so for now, only gate context creation for main video on having a hardware-initalized webview. This makes turning on accelerated canvas more convenient. BUG=332146 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245613

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
boliu
6 years, 11 months ago (2014-01-17 00:17:39 UTC) #1
no sievers
lgtm
6 years, 11 months ago (2014-01-17 17:50:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/boliu@chromium.org/137443020/1
6 years, 11 months ago (2014-01-17 18:12:23 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 20:59:02 UTC) #4
Message was sent while issue was closed.
Change committed as 245613

Powered by Google App Engine
This is Rietveld 408576698