Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 137443018: Revert 245051 "Don't set the scroll styles (WS_VSCROLL and WS_HS..." (Closed)

Created:
6 years, 11 months ago by alph
Modified:
6 years, 11 months ago
Reviewers:
ananta
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 245051 "Don't set the scroll styles (WS_VSCROLL and WS_HS..." Seems to be causing lots of layout test failures on Win7 > Don't set the scroll styles (WS_VSCROLL and WS_HSCROLL) for WS_POPUP windows. > > This causes issues with select boxes on Windows 7 where hovering at the end of the window returns the scroll WM_NCHITTEST > codes. Works fine on Windows 8. In any case we don't want the scrolling styles set on windows other than the main Chrome window > which is the only window which should be receive mousewheel messages. > > I moved the scroll style setting code from the HWNDMessageHandler::OnCreate function to HWNDMessageHandler::Init function as that > would prevent the initial WM_SIZE message from hiding the scrollbar. The other change is to hide the scrollbars and readd the > scroll styles if we are sizing the window, when the sizing completes. Basically when we receive the WM_EXITSIZEMOVE message. > For normal sizing operations we continue to do this in WM_SIZE as before. > > From testing on my thinkpad with Win7, desktop with Win7 and Win8 this works well. > > BUG=334454, 334541 > R=sky@chromium.org, sky > > Review URL: https://codereview.chromium.org/137403008 TBR=ananta@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245191

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -51 lines) Patch
M trunk/src/ui/views/win/hwnd_message_handler.h View 1 chunk +2 lines, -5 lines 0 comments Download
M trunk/src/ui/views/win/hwnd_message_handler.cc View 6 chunks +28 lines, -46 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
alph
6 years, 11 months ago (2014-01-16 10:01:54 UTC) #1
alph
6 years, 11 months ago (2014-01-16 10:02:07 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r245191 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698