Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 137443009: libaddressinput - merge LookupKeyUtil into Retriever (Closed)

Created:
6 years, 11 months ago by Evan Stade
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

libaddressinput - merge LookupKeyUtil into Retriever BUG=334317 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245117

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -192 lines) Patch
M third_party/libaddressinput/chromium/cpp/libaddressinput.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/lookup_key_util.h View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/src/lookup_key_util.cc View 1 chunk +0 lines, -46 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/retriever.h View 3 chunks +19 lines, -3 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/src/retriever.cc View 5 chunks +21 lines, -4 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/test/fake_downloader.cc View 1 4 chunks +2 lines, -9 lines 0 comments Download
D third_party/libaddressinput/chromium/cpp/test/lookup_key_util_test.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M third_party/libaddressinput/chromium/cpp/test/retriever_test.cc View 7 chunks +42 lines, -13 lines 0 comments Download
M third_party/libaddressinput/libaddressinput.gyp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
6 years, 11 months ago (2014-01-15 23:44:41 UTC) #1
please use gerrit instead
lgtm
6 years, 11 months ago (2014-01-16 00:51:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/137443009/30001
6 years, 11 months ago (2014-01-16 01:29:01 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 04:46:49 UTC) #4
Message was sent while issue was closed.
Change committed as 245117

Powered by Google App Engine
This is Rietveld 408576698