Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137443006: Remove support for <animateColor>. (Closed)

Created:
6 years, 11 months ago by Erik Dahlström (inactive)
Modified:
6 years, 10 months ago
Reviewers:
pdr., Stephen Chennney
CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), rwlbuis, dstockwell, Timothy Loh, krit, f(malita), Inactive, darktears, pdr, arv+blink, Stephen Chennney, Steve Block, dino_apple.com, watchdog-blink-watchlist_google.com, Eric Willigers
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove support for <animateColor>. Makes SVGAnimateColorElement an unknown DOM interface, but preserves HTML5 parsing rules (e.g ANIMATECOLOR -> animateColor). BUG=332839 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165071

Patch Set 1 #

Patch Set 2 : CR/LF sigh... #

Patch Set 3 : more test fixes #

Patch Set 4 : test adjustments #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -195 lines) Patch
M LayoutTests/svg/W3C-SVG-1.1/animate-elem-23-t.svg View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/W3C-SVG-1.1/animate-elem-30-t.svg View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/W3C-SVG-1.1/animate-elem-84-t.svg View 1 chunk +5 lines, -5 lines 0 comments Download
M LayoutTests/svg/W3C-SVG-1.1/animate-elem-85-t.svg View 1 chunk +8 lines, -8 lines 0 comments Download
M LayoutTests/svg/W3C-SVG-1.1/pservers-grad-19-b.svg View 3 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/svg/animations/animateColor-additive-2a-expected.svg View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M LayoutTests/svg/animations/animateColor-additive-2b-expected.svg View 1 2 3 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/svg/animations/animateColor-additive-2c-expected.svg View 1 2 3 1 chunk +12 lines, -12 lines 0 comments Download
M LayoutTests/svg/animations/animateColor-additive-2d-expected.svg View 1 2 3 1 chunk +12 lines, -12 lines 0 comments Download
LayoutTests/svg/animations/resources/additive-type-by-animation.svg View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/animations/script-tests/animate-color-fill-currentColor.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/animations/script-tests/animate-color-fill-from-by.js View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/animations/script-tests/animate-color-transparent.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/animations/script-tests/animate-currentColor.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/animations/script-tests/animate-inherit-css-property.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/svg/custom/animation-currentColor.svg View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/svg/custom/global-constructors-expected.txt View 1 2 1 chunk +1 line, -1 line 2 comments Download
M LayoutTests/svg/dom/svg2-inheritance-expected.txt View 1 2 3 1 chunk +1 line, -1 line 2 comments Download
M LayoutTests/virtual/stable/webexposed/global-constructors-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/webexposed/global-constructors-listing-expected.txt View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/core.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 chunk +0 lines, -1 line 0 comments Download
D Source/core/svg/SVGAnimateColorElement.h View 1 chunk +0 lines, -39 lines 0 comments Download
D Source/core/svg/SVGAnimateColorElement.cpp View 1 chunk +0 lines, -43 lines 0 comments Download
D Source/core/svg/SVGAnimateColorElement.idl View 1 chunk +0 lines, -28 lines 0 comments Download
M Source/core/svg/SVGAnimateElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/svg/SVGAnimateElement.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M Source/core/svg/SVGAnimatedColor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGAnimationElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTagNames.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/animation/SVGSMILElement.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Erik Dahlström (inactive)
6 years, 11 months ago (2014-01-14 13:56:34 UTC) #1
Stephen Chennney
LGTM, but please create a bug to leave open for cleanup, or update the existing ...
6 years, 11 months ago (2014-01-14 14:10:08 UTC) #2
Erik Dahlström (inactive)
https://codereview.chromium.org/137443006/diff/60021/LayoutTests/svg/custom/global-constructors-expected.txt File LayoutTests/svg/custom/global-constructors-expected.txt (right): https://codereview.chromium.org/137443006/diff/60021/LayoutTests/svg/custom/global-constructors-expected.txt#newcode140 LayoutTests/svg/custom/global-constructors-expected.txt:140: FAIL SVGAnimateColorElement.toString() should be function SVGAnimateColorElement() { [native code] ...
6 years, 11 months ago (2014-01-14 14:35:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ed@opera.com/137443006/60021
6 years, 11 months ago (2014-01-14 14:35:29 UTC) #4
commit-bot: I haz the power
Change committed as 165071
6 years, 11 months ago (2014-01-14 15:51:35 UTC) #5
pdr.
6 years, 10 months ago (2014-02-10 21:56:08 UTC) #6
Message was sent while issue was closed. 
On 2014/01/14 15:51:35, I haz the power (commit-bot) wrote:
> Change committed as 165071

Sadly, our super brittle UseCounter infrastructure broke with this change. See
crbug.com/342516 for details.

I don't think anyone's at fault here but please don't remove entries from
UseCounter.h. Ojan is going to add numbers to the UseCounter enum to make this
more clear.

Powered by Google App Engine
This is Rietveld 408576698