Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/compiler/BUILD.gn

Issue 1374423002: Add UBsan vtpr support to GN. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-ubsan
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/config/BUILD.gn ('k') | build/config/sanitizers/BUILD.gn » ('j') | build/config/sanitizers/sanitizers.gni » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index e9fca3b9e3ce4fcc98033c63586899bbe623bb77..8ded38de3116e9ae86cc9b2e2b8d4e607571f3a0 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -831,8 +831,8 @@ config("rtti") {
}
}
config("no_rtti") {
- # CFI diagnostics require RTTI.
- if (!use_cfi_diag) {
+ # CFI diagnostics and UBsan vptr require RTTI.
+ if (!use_cfi_diag && !is_ubsan_vptr) {
if (is_win) {
cflags_cc = [ "/GR-" ]
} else {
« no previous file with comments | « build/config/BUILD.gn ('k') | build/config/sanitizers/BUILD.gn » ('j') | build/config/sanitizers/sanitizers.gni » ('J')

Powered by Google App Engine
This is Rietveld 408576698