Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1374383004: SkPDF: when drawing stroked path, draw using SVG rules for zero-length segments (Closed)

Created:
5 years, 2 months ago by hal.canary
Modified:
5 years, 2 months ago
Reviewers:
caryclark, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkPDF: when drawing stroked path, draw using SVG rules for zero-length segments The "zeroPath" and emptystroke GMs capture this issue. This CL changes the following PDF GMs: emptystroke dashing4 lineclosepath dashing3 zeroPath linepath complexclip3_complex complexclip3_simple roundrects degeneratesegments filltypes strokerect pathfill inverse_paths desk_chalkboard.skp After this change, all PDF GMs look better (closer to 8888). The dashing4, emptystroke, and zeroPath GMs still need a lot of work to make them look right. BUG=538726 Committed: https://skia.googlesource.com/skia/+/8b2bc252faed7c751cf9248c3833c0631f498b7d

Patch Set 1 #

Patch Set 2 : 2015-10-06 (Tuesday) 10:18:30 EDT #

Patch Set 3 : 2015-10-06 (Tuesday) 10:21:32 EDT #

Patch Set 4 : 2015-10-06 (Tuesday) 12:31:14 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -18 lines) Patch
A gm/path_stroke_with_zero_length.cpp View 1 2 3 1 chunk +54 lines, -0 lines 0 comments Download
M src/pdf/SkPDFDevice.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M src/pdf/SkPDFUtils.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/pdf/SkPDFUtils.cpp View 1 4 chunks +18 lines, -17 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
hal.canary
PTAL
5 years, 2 months ago (2015-10-05 16:02:06 UTC) #2
caryclark
lgtm
5 years, 2 months ago (2015-10-05 16:07:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374383004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374383004/1
5 years, 2 months ago (2015-10-05 16:10:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/3473)
5 years, 2 months ago (2015-10-05 16:19:04 UTC) #7
reed1
lets add a test and/or docs before we land this
5 years, 2 months ago (2015-10-05 16:58:33 UTC) #9
f(malita)
On 2015/10/05 16:58:33, reed1 wrote: > lets add a test and/or docs before we land ...
5 years, 2 months ago (2015-10-06 14:50:27 UTC) #10
hal.canary
On 2015/10/05 16:58:33, reed1 wrote: > lets add a test and/or docs before we land ...
5 years, 2 months ago (2015-10-06 16:34:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374383004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374383004/60001
5 years, 2 months ago (2015-10-06 16:35:09 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-06 16:41:52 UTC) #15
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8b2bc252faed7c751cf9248c3833c0631f498b7d

Powered by Google App Engine
This is Rietveld 408576698