tools/checkperms/checkperms.py - Issue 1374373007: Make checkperms.py --bare also return failure reason

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/checkperms/checkperms.py

Issue 1374373007: Make checkperms.py --bare also return failure reason (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/checkperms/checkperms.py

diff --git a/tools/checkperms/checkperms.py b/tools/checkperms/checkperms.py

index 604c7f7dcf30050c417ea84a9299555d29559d20..1be437e6101cd63328fba513cf307c75bf421a0f 100755

--- a/tools/checkperms/checkperms.py

+++ b/tools/checkperms/checkperms.py

@@ -461,11 +461,9 @@ Examples:

json.dump(errors, f)

if errors:

- if options.bare:

- print '\n'.join(e['full_path'] for e in errors)

- else:

+ if not options.bare:

print '\nFAILED\n'

- print '\n'.join('%s: %s' % (e['full_path'], e['error']) for e in errors)

+ print '\n'.join('%s: %s' % (e['full_path'], e['error']) for e in errors)

return 1

if not options.bare:

print '\nSUCCESS\n'

« no previous file with comments | « no previous file | no next file » | no next file with comments »