Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Unified Diff: runtime/vm/pages.h

Issue 1374373004: Clarify heap write protection interface and use WritableVMIsolateScope to resolve issue 23217. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/pages.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/pages.h
diff --git a/runtime/vm/pages.h b/runtime/vm/pages.h
index e67bc812f0e7c842336d5c48bb3c1a3d5609db25..f7acf90e0d7f516fbc752d51518132b6fb0a2391 100644
--- a/runtime/vm/pages.h
+++ b/runtime/vm/pages.h
@@ -277,7 +277,8 @@ class PageSpace {
(ExternalInWords() > max_external_in_words_);
}
- // TODO(koda): Unify protection handling.
+ // Note: Code pages are made executable/non-executable when 'read_only' is
+ // true/false, respectively.
void WriteProtect(bool read_only);
void WriteProtectCode(bool read_only);
« no previous file with comments | « runtime/vm/object.cc ('k') | runtime/vm/pages.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698