Refactor consumeFontVariant

Refactor consumeFontVariant

Refactor consumeFontVariant by splitting it in a part for
@font-face and a part for the property. This makes the code
a bit easier to read and allows consumeFontVariant to
become a free function.

BUG=499780
Committed: https://crrev.com/0f2a9072129d9578fa15aa36e955a8b93cdbb15e
Cr-Commit-Position: refs/heads/master@{#351950}

[rwlbuis, 2015-10-01 21:00:16]

rob.buis@samsung.com changed reviewers:
+ alancutter@chromium.org, timloh@chromium.org

[rwlbuis, 2015-10-01 21:00:16]

PTAL. Note that I changed parseFontFaceDescriptor to not use parseSingleValue
parseSingleValue, since in that case consumeWhitespace() is being called twice.
That part of the patch is pretty optional though, I thing splitting up
consumeFontVariant is the more important part. I'll try to reuse
consumeFontVariant in the font shorthand too.

[Timothy Loh, 2015-10-02 01:46:26]

On 2015/10/01 21:00:16, rwlbuis wrote:
> PTAL. Note that I changed parseFontFaceDescriptor to not use parseSingleValue
> parseSingleValue, since in that case consumeWhitespace() is being called
twice.
> That part of the patch is pretty optional though, I thing splitting up
> consumeFontVariant is the more important part. I'll try to reuse
> consumeFontVariant in the font shorthand too.

lgtm

[rwlbuis, 2015-10-02 02:02:04]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2015-10-02 02:03:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1374353003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1374353003/1

[commit-bot: I haz the power, 2015-10-02 03:31:06]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-02 03:31:45]

Patchset 1 (id:??) landed as
https://crrev.com/0f2a9072129d9578fa15aa36e955a8b93cdbb15e
Cr-Commit-Position: refs/heads/master@{#351950}