Switch to EmbeddedTestServer to avoid flakiness.

Switch to EmbeddedTestServer to avoid flakiness.

Flake at http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28valgrind%29%284%29/builds/24523/steps/memory%20test%3A%20unit/logs/stdio

[ RUN      ] WebRequestConditionAttributeTest.ResponseHeaders
[4593:4593:0203/083335:1568179503:ERROR:local_test_server_posix.cc(76)] poll() timed out; bytes_read=0
[4593:4593:0203/083335:1568183325:ERROR:local_test_server_posix.cc(159)] Could not read server_data_len
HTTP server started on 127.0.0.1:55369...
sending server_data: {"host": "127.0.0.1", "port": 55369} (36 bytes)
../../chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc:508: Failure
Value of: test_server.Start()
  Actual: false
  Expected: true
  [  FAILED  ] WebRequestConditionAttributeTest.ResponseHeaders (11177 ms)

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248862

[vabr (Chromium), 2014-02-03 23:22:49]

On 2014/02/03 20:51:04, Jeffrey Yasskin wrote:

LGTM, Thanks, Jeffrey!

Just for my future reference, what is the difference when one should chose the
embedded and when the spawned server?

Cheers,
Vaclav

[Jeffrey Yasskin, 2014-02-04 00:54:37]

On Mon, Feb 3, 2014 at 3:22 PM,  <vabr@chromium.org> wrote:
> On 2014/02/03 20:51:04, Jeffrey Yasskin wrote:
>
> LGTM, Thanks, Jeffrey!
>
> Just for my future reference, what is the difference when one should chose
> the
> embedded and when the spawned server?

I believe one should always use the embedded server if it's possible.
+Pawel to double-check.

The current patch is missing an update for the .isolate file, so I'll
be adding a new patch before CQing it.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Paweł Hajdan Jr., 2014-02-04 01:16:56]

LGTM!

Thanks, that's awesome thing to do. If you'd like to do more, feel free. :)

[Jeffrey Yasskin, 2014-02-04 04:28:17]

On 2014/02/04 00:54:37, Jeffrey Yasskin wrote:
> The current patch is missing an update for the .isolate file, so I'll
> be adding a new patch before CQing it.

It turns out we should have been using PathService to get the source directory
instead of assuming it was under the current directory. I'll check the commit
bit tomorrow morning.

[vabr (Chromium), 2014-02-04 08:19:12]

Still LGTM. Thanks for another educative patch, Jeffrey!
Vaclav

https://codereview.chromium.org/137433010/diff/110001/chrome/browser/extensio...
File
chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
(right):

https://codereview.chromium.org/137433010/diff/110001/chrome/browser/extensio...
chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc:684:
}  // namespace
Did you put the whole test into anonymous namespace on purpose? I guess that
makes sense, because it's not exported anywhere, it's just the first time I see
it.

[Jeffrey Yasskin, 2014-02-04 08:27:17]

https://codereview.chromium.org/137433010/diff/110001/chrome/browser/extensio...
File
chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
(right):

https://codereview.chromium.org/137433010/diff/110001/chrome/browser/extensio...
chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc:684:
}  // namespace
On 2014/02/04 08:19:12, vabr (Chromium) wrote:
> Did you put the whole test into anonymous namespace on purpose? I guess that
> makes sense, because it's not exported anywhere, it's just the first time I
see
> it.

Yeah. It's nice to do that because it ensures that we can write helper functions
anywhere in the file without worrying that they'll collide with other helper
functions. If we need to use FRIEND_TEST, we can't put that test in an anonymous
namespace, but otherwise, it's a good practice.

[Jeffrey Yasskin, 2014-02-04 16:57:20]

The CQ bit was checked by jyasskin@chromium.org

[commit-bot: I haz the power, 2014-02-04 16:59:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/137433010/110001

[commit-bot: I haz the power, 2014-02-04 18:10:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-04 18:10:26]

Retried try job too often on win_rel for step(s) sync_integration_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[Jeffrey Yasskin, 2014-02-04 18:18:37]

The CQ bit was checked by jyasskin@chromium.org

[commit-bot: I haz the power, 2014-02-04 18:20:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/137433010/110001

[commit-bot: I haz the power, 2014-02-04 20:23:54]

Retried try job too often on win_rel for step(s) base_unittests, browser_tests,
interactive_ui_tests, net_unittests, sync_integration_tests, unit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-02-04 20:25:17]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/137433010/110001

[commit-bot: I haz the power, 2014-02-05 00:49:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jyasskin@chromium.org/137433010/110001

[commit-bot: I haz the power, 2014-02-05 05:31:27]

Change committed as 248862