Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(970)

Side by Side Diff: Source/core/html/HTMLSelectElement.cpp

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLSelectElement.h ('k') | Source/core/html/HTMLSelectElement.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 2 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 1999 Antti Koivisto (koivisto@kde.org) 4 * (C) 1999 Antti Koivisto (koivisto@kde.org)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved. 6 * Copyright (C) 2004, 2005, 2006, 2007, 2009, 2010, 2011 Apple Inc. All rights reserved.
7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com) 7 * (C) 2006 Alexey Proskuryakov (ap@nypop.com)
8 * Copyright (C) 2010 Google Inc. All rights reserved. 8 * Copyright (C) 2010 Google Inc. All rights reserved.
9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/) 9 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmo bile.com/)
10 * 10 *
(...skipping 368 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 // selection as single-line and multi-line has different defaults. 379 // selection as single-line and multi-line has different defaults.
380 if (oldMultiple != this->multiple()) 380 if (oldMultiple != this->multiple())
381 setSelectedIndex(oldSelectedIndex); 381 setSelectedIndex(oldSelectedIndex);
382 } 382 }
383 383
384 void HTMLSelectElement::setSize(int size) 384 void HTMLSelectElement::setSize(int size)
385 { 385 {
386 setIntegralAttribute(sizeAttr, size); 386 setIntegralAttribute(sizeAttr, size);
387 } 387 }
388 388
389 Node* HTMLSelectElement::namedItem(const AtomicString& name) 389 Element* HTMLSelectElement::namedItem(const AtomicString& name)
390 { 390 {
391 return options()->namedItem(name); 391 return options()->namedItem(name);
392 } 392 }
393 393
394 Node* HTMLSelectElement::item(unsigned index) 394 Element* HTMLSelectElement::item(unsigned index)
395 { 395 {
396 return options()->item(index); 396 return options()->item(index);
397 } 397 }
398 398
399 void HTMLSelectElement::setOption(unsigned index, HTMLOptionElement* option, Exc eptionState& exceptionState) 399 void HTMLSelectElement::setOption(unsigned index, HTMLOptionElement* option, Exc eptionState& exceptionState)
400 { 400 {
401 if (index > maxSelectItems - 1) 401 if (index > maxSelectItems - 1)
402 index = maxSelectItems - 1; 402 index = maxSelectItems - 1;
403 int diff = index - length(); 403 int diff = index - length();
404 RefPtr<HTMLElement> before = 0; 404 RefPtr<HTMLElement> before = 0;
(...skipping 1157 matching lines...) Expand 10 before | Expand all | Expand 10 after
1562 { 1562 {
1563 return true; 1563 return true;
1564 } 1564 }
1565 1565
1566 bool HTMLSelectElement::supportsAutofocus() const 1566 bool HTMLSelectElement::supportsAutofocus() const
1567 { 1567 {
1568 return true; 1568 return true;
1569 } 1569 }
1570 1570
1571 } // namespace 1571 } // namespace
OLDNEW
« no previous file with comments | « Source/core/html/HTMLSelectElement.h ('k') | Source/core/html/HTMLSelectElement.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698