Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: Source/core/html/HTMLAllCollection.cpp

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLAllCollection.h ('k') | Source/core/html/HTMLAllCollection.idl » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009, 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2009, 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 28 matching lines...) Expand all
39 HTMLAllCollection::HTMLAllCollection(ContainerNode* node, CollectionType type) 39 HTMLAllCollection::HTMLAllCollection(ContainerNode* node, CollectionType type)
40 : HTMLCollection(node, type, DoesNotOverrideItemAfter) 40 : HTMLCollection(node, type, DoesNotOverrideItemAfter)
41 { 41 {
42 ScriptWrappable::init(this); 42 ScriptWrappable::init(this);
43 } 43 }
44 44
45 HTMLAllCollection::~HTMLAllCollection() 45 HTMLAllCollection::~HTMLAllCollection()
46 { 46 {
47 } 47 }
48 48
49 Node* HTMLAllCollection::namedItemWithIndex(const AtomicString& name, unsigned i ndex) const 49 Element* HTMLAllCollection::namedItemWithIndex(const AtomicString& name, unsigne d index) const
50 { 50 {
51 updateNameCache(); 51 updateNameCache();
52 52
53 if (Vector<Element*>* cache = idCache(name)) { 53 if (Vector<Element*>* cache = idCache(name)) {
54 if (index < cache->size()) 54 if (index < cache->size())
55 return cache->at(index); 55 return cache->at(index);
56 index -= cache->size(); 56 index -= cache->size();
57 } 57 }
58 58
59 if (Vector<Element*>* cache = nameCache(name)) { 59 if (Vector<Element*>* cache = nameCache(name)) {
(...skipping 23 matching lines...) Expand all
83 returnValue0Enabled = true; 83 returnValue0Enabled = true;
84 returnValue0 = NamedNodesCollection::create(namedItems); 84 returnValue0 = NamedNodesCollection::create(namedItems);
85 } 85 }
86 86
87 PassRefPtr<HTMLCollection> HTMLAllCollection::tags(const AtomicString& name) 87 PassRefPtr<HTMLCollection> HTMLAllCollection::tags(const AtomicString& name)
88 { 88 {
89 return ownerNode()->getElementsByTagName(name); 89 return ownerNode()->getElementsByTagName(name);
90 } 90 }
91 91
92 } // namespace WebCore 92 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLAllCollection.h ('k') | Source/core/html/HTMLAllCollection.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698