Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1374313007: Fix for incremental resolver - changing field formal parameter name is sometimes a non-incremental … (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix for incremental resolver - changing field formal parameter name is sometimes a non-incremental change. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/c4427ca8f4cc5ac34eb6cb06fff3e2bee4ae8ce9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -9 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 5 chunks +91 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
5 years, 2 months ago (2015-10-06 04:05:48 UTC) #1
Brian Wilkerson
LGTM
5 years, 2 months ago (2015-10-06 13:17:00 UTC) #2
Paul Berry
lgtm
5 years, 2 months ago (2015-10-06 15:27:28 UTC) #3
scheglov
5 years, 2 months ago (2015-10-06 15:35:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c4427ca8f4cc5ac34eb6cb06fff3e2bee4ae8ce9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698