Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8124)

Unified Diff: chrome/browser/sync/test/integration/sync_errors_test.cc

Issue 13743003: sync: Finish the SyncScheduler refactor (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix AuthErrorTest Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/profile_sync_service_harness.h ('k') | sync/engine/sync_scheduler_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/test/integration/sync_errors_test.cc
diff --git a/chrome/browser/sync/test/integration/sync_errors_test.cc b/chrome/browser/sync/test/integration/sync_errors_test.cc
index 6fb9c71df1833de4ad7d39055a72ae94a383649b..87d29a5b1f7e891b226c1132dd4ee9b73c678c15 100644
--- a/chrome/browser/sync/test/integration/sync_errors_test.cc
+++ b/chrome/browser/sync/test/integration/sync_errors_test.cc
@@ -140,20 +140,13 @@ IN_PROC_BROWSER_TEST_F(SyncErrorTest,
protocol_error.error_description);
}
-// Trigger an auth error and make sure the sync client detects it when
-// trying to commit.
+// Trigger an auth error and make sure the sync client displays a warning in the
+// UI.
IN_PROC_BROWSER_TEST_F(SyncErrorTest, AuthErrorTest) {
- ASSERT_TRUE(SetupSync()) << "SetupSync() failed.";
-
- const BookmarkNode* node1 = AddFolder(0, 0, L"title1");
- SetTitle(0, node1, L"new_title1");
- ASSERT_TRUE(GetClient(0)->AwaitFullSyncCompletion("Sync."));
-
+ ASSERT_TRUE(SetupClients());
TriggerAuthError();
- const BookmarkNode* node2 = AddFolder(0, 0, L"title2");
- SetTitle(0, node2, L"new_title2");
- ASSERT_TRUE(GetClient(0)->AwaitExponentialBackoffVerification());
+ ASSERT_FALSE(GetClient(0)->SetupSync());
ASSERT_EQ(GoogleServiceAuthError::INVALID_GAIA_CREDENTIALS,
GetClient(0)->service()->GetAuthError().state());
}
« no previous file with comments | « chrome/browser/sync/profile_sync_service_harness.h ('k') | sync/engine/sync_scheduler_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698