Add non-git-svn checkout to fetch.py.

Add non-git-svn checkout to fetch.py.

Also modify the chromium and blink recipes to only use the gclient-git
checkout method if the user specifies --anonymous=True on the command line.

A better command-line parsing system is coming in the near future, so don't
worry about the "if props.get('anonymous', 'False') != 'True'" too much.

R=dpranke@chromium.org,iannucci@chromium.org

[agable, 2013-04-06 00:41:34]

Here's the --anonymous=True change.

[iannucci, 2013-04-06 01:38:18]

lgtm w/ comments

https://codereview.chromium.org/13743002/diff/1/fetch.py
File fetch.py (right):

https://codereview.chromium.org/13743002/diff/1/fetch.py#newcode70
fetch.py:70: return os.path.exists(os.path.join(os.getcwd(), self.root))
Let's make self.root abspath from the initial set.

https://codereview.chromium.org/13743002/diff/1/fetch.py#newcode96
fetch.py:96: for key in self.spec if key in keys)
This should be a function (spec'ifying a dict).

https://codereview.chromium.org/13743002/diff/1/fetch.py#newcode99
fetch.py:99: def init(self):
This should call super.

https://codereview.chromium.org/13743002/diff/1/fetch.py#newcode101
fetch.py:101: self.run_git('config', '--global', 'core.deltaBaseCacheLimit',
'1G')
*grumble*

https://codereview.chromium.org/13743002/diff/1/fetch.py#newcode111
fetch.py:111: self.run_git(
run_git should print cwd on dryrun... don't need to do it specially here

https://codereview.chromium.org/13743002/diff/1/fetch.py#newcode147
fetch.py:147: self.run_git('config', 'diff.ignoreSubmodules', 'all', cwd=wd)
This should be a call to super

[Dirk Pranke, 2013-04-06 01:45:25]

On the description: 

If you can, it's best to lead with what the user-visible changes are, and then
discuss what (how/why) the changes are that implement this, e.g.:

Add support for anonymous/non-committers to 'fetch'

Currently the recipes expect you to be a committer, but not everyone is. This
gives non-committers an easy option as well. 

To do that, we add a 'GclientGitCheckout' class to fetch.py and the following
parameters [...] to the recipes to support this"

Or something like the above.

We should also document the format of the recipes somewhere (e.g., in
recipe_util.Recipe) so it can be clear what all of the supported parameters are.

And we still need tests. Given that people are actually using this command now,
we should probably have them here (at least minimal smoke tests to ensure that
the command line arguments don't cause crashes).

https://codereview.chromium.org/13743002/diff/1/fetch
File fetch (left):

https://codereview.chromium.org/13743002/diff/1/fetch#oldcode10
fetch:10: fi
NIt: ideally I would've cleaned this up in a separate patch

https://codereview.chromium.org/13743002/diff/1/fetch.py
File fetch.py (right):

https://codereview.chromium.org/13743002/diff/1/fetch.py#newcode69
fetch.py:69: def exists(self):
I know this name was already chosen, but it's not very good :) Can we rename
this to CheckoutAlreadyExists() or something? We should also consider checking
if a '.gclient' file exists in the cwd.

https://codereview.chromium.org/13743002/diff/1/fetch.py#newcode118
fetch.py:118: class GclientGitSvnCheckout(GclientCheckout, GitCheckout,
SvnCheckout):
Should this inherit from GclientGitCheckout instead of GclientCheckout and
GitCheckout?

https://codereview.chromium.org/13743002/diff/1/fetch.py#newcode194
fetch.py:194: """ % os.path.basename(sys.argv[0]))
Since we're hacking here, we should add in a comment about --anonymous=true here
for now, and fix this down the road w/ proper arg parsing (which would not
require the '=true' part). Please make sure the usage mentions something about 
non-committer or non-commit so that it's clearer that anonymous is also for
people who are contributors who might have accounts but aren't yet committers.

https://codereview.chromium.org/13743002/diff/1/recipes/blink.py
File recipes/blink.py (right):

https://codereview.chromium.org/13743002/diff/1/recipes/blink.py#newcode17
recipes/blink.py:17: if props.get('anonymous', 'False') != 'True':
I saw the comment, but clearly at some point this should end up as something
like "if not props.get('anonymous'):"