chrome/browser/task_management/providers/web_contents/renderer_task.h - Issue 1374283003: Reporting top cpu and memory consumers via rappor on chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/providers/web_contents/renderer_task.h

Issue 1374283003: Reporting top cpu and memory consumers via rappor on chromeos (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: derat's comments Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/chromeos/resource_reporter/resource_reporter.cc ('K') | « chrome/browser/task_management/providers/task.cc ('k') | chrome/browser/task_management/providers/web_contents/renderer_task.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/providers/web_contents/renderer_task.h

diff --git a/chrome/browser/task_management/providers/web_contents/renderer_task.h b/chrome/browser/task_management/providers/web_contents/renderer_task.h

index d28770af97a5231627e1d2e5b6611ca38582378e..9baed1011ae5361640b13c6c0a41a4c2f0623b2f 100644

--- a/chrome/browser/task_management/providers/web_contents/renderer_task.h

+++ b/chrome/browser/task_management/providers/web_contents/renderer_task.h

@@ -40,6 +40,11 @@ class RendererTask : public Task,

// can update their favicons.

virtual void UpdateFavicon() = 0;

+ // An overridable method that will be called when the event

+ // WebContentsObserver::DidNavigateMainFrame() occurs, so that we can update

+ // their Rappor sample name when a navigation takes place.

+ virtual void UpdateRapporSampleName();

// task_management::Task:

void Activate() override;

void Refresh(const base::TimeDelta& update_interval,