Reporting top cpu and memory consumers via rappor on chromeos

chrome/browser/task_management/sampling/task_group_sampler.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/task_management/sampling/task_group_sampler.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "chrome/browser/task_management/task_manager_observer.h"
 #include "content/public/browser/browser_child_process_host.h"
@@ skipping 13 matching lines @@
 }
 
 inline bool IsResourceRefreshEnabled(RefreshType refresh_type,
                                      int refresh_flags) {
   return (refresh_flags & refresh_type) != 0;
 }
 
 }  // namespace
 
 TaskGroupSampler::TaskGroupSampler(
+    base::ProcessId proc_id,
     base::ProcessHandle proc_handle,
     const scoped_refptr<base::SequencedTaskRunner>& blocking_pool_runner,
     const OnCpuRefreshCallback& on_cpu_refresh,
     const OnMemoryRefreshCallback& on_memory_refresh,
-    const OnIdleWakeupsCallback& on_idle_wakeups)
+    const OnIdleWakeupsCallback& on_idle_wakeups,
+    const OnProcessPriorityCallback& on_process_priority)
     : process_metrics_(CreateProcessMetrics(proc_handle)),
       blocking_pool_runner_(blocking_pool_runner),
+      process_(base::Process::Open(proc_id)),

[ncarter (slow), 2015/11/20 18:44:45]

If we're doing base::Process::Open here, that gives us our own durable handle to
the pid, so we can pass that to process_metrics_. It's always better to use a
handle that you own, because using a handle that's been closed can result in a
crash.

I suggest .Pass()-ing a base::Process into the TaskGroupSampler ctor (replacing
both proc_id and proc_handle). Have the calling function do the Open call. 

[afakhry, 2015/11/21 01:32:58]

Thanks for this suggestion. It matches our decision to rely on the process id in
all the new task manager code. The only thing that still used a process handle
is the ProcessMetrics.

Done. Please take a look.

       on_cpu_refresh_callback_(on_cpu_refresh),
       on_memory_refresh_callback_(on_memory_refresh),
-      on_idle_wakeups_callback_(on_idle_wakeups) {
+      on_idle_wakeups_callback_(on_idle_wakeups),
+      on_process_priority_callback_(on_process_priority) {
   DCHECK(blocking_pool_runner.get());
 
   // This object will be created on the UI thread, however the sequenced checker
   // will be used to assert we're running the expensive operations on one of the
   // blocking pool threads.
   DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
   worker_pool_sequenced_checker_.DetachFromSequence();
 }
 
 void TaskGroupSampler::Refresh(int64 refresh_flags) {
@@ skipping 17 matching lines @@
 
 #if defined(OS_MACOSX) || defined(OS_LINUX)
   if (IsResourceRefreshEnabled(REFRESH_TYPE_IDLE_WAKEUPS, refresh_flags)) {
     base::PostTaskAndReplyWithResult(
         blocking_pool_runner_.get(),
         FROM_HERE,
         base::Bind(&TaskGroupSampler::RefreshIdleWakeupsPerSecond, this),
         on_idle_wakeups_callback_);
   }
 #endif  // defined(OS_MACOSX) || defined(OS_LINUX)
+
+  if (IsResourceRefreshEnabled(REFRESH_TYPE_PRIORITY, refresh_flags)) {
+    base::PostTaskAndReplyWithResult(
+        blocking_pool_runner_.get(),
+        FROM_HERE,
+        base::Bind(&TaskGroupSampler::RefreshProcessPriority, this),
+        on_process_priority_callback_);
+  }
 }
 
 TaskGroupSampler::~TaskGroupSampler() {
 }
 
 double TaskGroupSampler::RefreshCpuUsage() {
   DCHECK(worker_pool_sequenced_checker_.CalledOnValidSequencedThread());
 
   return process_metrics_->GetCPUUsage();
 }
@@ skipping 28 matching lines @@
 
   return memory_usage;
 }
 
 int TaskGroupSampler::RefreshIdleWakeupsPerSecond() {
   DCHECK(worker_pool_sequenced_checker_.CalledOnValidSequencedThread());
 
   return process_metrics_->GetIdleWakeupsPerSecond();
 }
 
+bool TaskGroupSampler::RefreshProcessPriority() {
+  DCHECK(worker_pool_sequenced_checker_.CalledOnValidSequencedThread());
+
+  return process_.IsProcessBackgrounded();
+}
+
 }  // namespace task_management