Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1374263004: Fix other build errors from r352208. (Closed)

Created:
5 years, 2 months ago by jam
Modified:
5 years, 2 months ago
Reviewers:
yzshen1
CC:
chromium-reviews, asanka, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, benjhayden+dwatch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix other build errors from r352208. They only shows up on the full clobber builder. TBR=yzshen@chromium.org BUG=478251 Committed: https://crrev.com/8561d87a81a35484fa9e167583e390901665258f Cr-Commit-Position: refs/heads/master@{#352227}

Patch Set 1 #

Patch Set 2 : more #

Patch Set 3 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M mojo/edk/embedder/embedder_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_unittest.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/edk/test/BUILD.gn View 1 2 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
jam
5 years, 2 months ago (2015-10-03 01:37:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374263004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374263004/1
5 years, 2 months ago (2015-10-03 01:38:08 UTC) #3
Lei Zhang
Revision number is wrong BTW.
5 years, 2 months ago (2015-10-03 02:31:51 UTC) #4
jam
On 2015/10/03 02:31:51, Lei Zhang wrote: > Revision number is wrong BTW. Thanks. Not sure ...
5 years, 2 months ago (2015-10-03 02:36:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374263004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374263004/40001
5 years, 2 months ago (2015-10-03 02:37:25 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-10-03 02:43:14 UTC) #8
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/8561d87a81a35484fa9e167583e390901665258f Cr-Commit-Position: refs/heads/master@{#352227}
5 years, 2 months ago (2015-10-03 02:43:59 UTC) #9
yzshen1
5 years, 2 months ago (2015-10-03 16:48:25 UTC) #10
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698