Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 1374233003: Remove SVGSVGElement.pixelUnitToMillimeterX and friends (Closed)

Created:
5 years, 2 months ago by philipj_slow
Modified:
5 years, 2 months ago
Reviewers:
fs, timvolodine
CC:
fs, android-webview-reviews_chromium.org, blink-reviews, Inactive, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove SVGSVGElement.pixelUnitToMillimeterX and friends Intent to Deprecate and Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/uJCmB7SzYNo/cBASMfJuBAAJ BUG=537177 R=fs@opera.com, timvolodine@chromium.org Committed: https://crrev.com/d51cbbbf9a2197aeea058492ec3df94022233f80 Cr-Commit-Position: refs/heads/master@{#351540}

Patch Set 1 #

Messages

Total messages: 14 (3 generated)
philipj_slow
5 years, 2 months ago (2015-09-30 08:40:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374233003/1
5 years, 2 months ago (2015-09-30 08:40:20 UTC) #3
fs
lgtm
5 years, 2 months ago (2015-09-30 09:10:24 UTC) #4
timvolodine
WebViewShell/.. -- lgtm, thanks!
5 years, 2 months ago (2015-09-30 09:31:17 UTC) #5
philipj_slow
On 2015/09/30 09:31:17, timvolodine wrote: > WebViewShell/.. -- lgtm, thanks! It's a lot easier to ...
5 years, 2 months ago (2015-09-30 09:35:01 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/75624)
5 years, 2 months ago (2015-09-30 11:41:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374233003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374233003/1
5 years, 2 months ago (2015-09-30 11:58:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-30 13:12:52 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d51cbbbf9a2197aeea058492ec3df94022233f80 Cr-Commit-Position: refs/heads/master@{#351540}
5 years, 2 months ago (2015-09-30 13:13:40 UTC) #12
paulmiller
WebViewShell is copied in Android at packages/apps/Browser2 and changes should generally be made in both ...
5 years, 2 months ago (2015-09-30 17:23:32 UTC) #13
timvolodine
5 years, 2 months ago (2015-09-30 18:21:05 UTC) #14
Message was sent while issue was closed.
On 2015/09/30 17:23:32, paulmiller wrote:
> WebViewShell is copied in Android at packages/apps/Browser2 and changes should
> generally be made in both places. I'll merge this one. Tim, since you own the
> shell, can you help make sure they don't fork? (We weren't anticipating a lot
of
> changes when we copied the code. Maybe we were wrong.)

paulmiller@:
the WebViewShell/test directory relates to the WebView L bot we have on the
waterfall, the global-interfaces file gets changed relatively often so don't
think it's practical to keep it updated in android with every change. As far as
I understand the whole purpose of the Browser2 is to provide a mini-shell for
running webview (not the tests).

I've cc'ed you on recent threads regarding some renaming/refactoring of
WebViewShell. Ideally in the end we would have a system_webview_shell/apk/ or so
directory with the browser only which could be copied to android.

Powered by Google App Engine
This is Rietveld 408576698