Issue 137423013: [chromedriver] Enable a java test and fix binary path like "~/chrome".

Issue 137423013: [chromedriver] Enable a java test and fix binary path like "~/chrome". (Closed)

Created:
6 years, 10 months ago by stgao

Modified:
6 years, 10 months ago

Reviewers:
craigdh

CC:
chromium-reviews, frankf, samuong

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[chromedriver] Enable a java test and fix binary path like "~/chrome". The java test is fixed in https://codereview.chromium.org/147083010/ BUG=None R=craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247796

Patch Set 2 : Address comments. #

Patch Set 3 : Rebase for manual commit #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
M	chrome/test/chromedriver/test/run_java_tests.py	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/test/run_py_tests.py	View		2 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/test/chromedriver/test/test_expectations	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/test/chromedriver/util.py	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

stgao

This Cl will be committed after https://codereview.chromium.org/147083010/.

6 years, 10 months ago (2014-01-28 21:28:17 UTC) #1

stgao

please also take a look at this CL. It will be manually committed after https://codereview.chromium.org/147083010/.

6 years, 10 months ago (2014-01-28 21:36:58 UTC) #2

craigdh

lgtm w/ comment https://codereview.chromium.org/137423013/diff/1/chrome/test/chromedriver/util.py File chrome/test/chromedriver/util.py (right): https://codereview.chromium.org/137423013/diff/1/chrome/test/chromedriver/util.py#newcode45 chrome/test/chromedriver/util.py:45: if not user_path: The empty string ...

6 years, 10 months ago (2014-01-29 18:47:35 UTC) #3

stgao

https://codereview.chromium.org/137423013/diff/1/chrome/test/chromedriver/util.py File chrome/test/chromedriver/util.py (right): https://codereview.chromium.org/137423013/diff/1/chrome/test/chromedriver/util.py#newcode45 chrome/test/chromedriver/util.py:45: if not user_path: On 2014/01/29 18:47:35, craigdh wrote: > ...

6 years, 10 months ago (2014-01-29 19:40:27 UTC) #4

stgao

6 years, 10 months ago (2014-01-30 01:08:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r247796 (presubmit successful).

Expand Messages | Collapse Messages