Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 137423010: drive: Support offline file creation (Closed)

Created:
6 years, 10 months ago by hashimoto
Modified:
6 years, 10 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Support offline file creation BUG=260539 TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248138

Patch Set 1 : #

Total comments: 1

Patch Set 2 : rebase #

Messages

Total messages: 3 (0 generated)
hashimoto
https://codereview.chromium.org/137423010/diff/20001/chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc File chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc (right): https://codereview.chromium.org/137423010/diff/20001/chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc#newcode43 chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc:43: if (!quit_closure_.is_null()) This null check is needed because CreateFileOpreration ...
6 years, 10 months ago (2014-01-30 04:25:50 UTC) #1
kinaba
lgtm
6 years, 10 months ago (2014-01-31 03:19:22 UTC) #2
hashimoto
6 years, 10 months ago (2014-01-31 05:50:16 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 manually as r248138 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698