Issue 137423010: drive: Support offline file creation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 137423010: drive: Support offline file creation (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 8 months ago by hashimoto

Modified:
3 years, 7 months ago

Reviewers:
kinaba

CC:
chromium-reviews, nkostylev+watch_chromium.org, tzik, tfarina, nhiroki, oshima+watch_chromium.org, kinuko+watch, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Support offline file creation BUG=260539 TEST=unit_tests R=kinaba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248138

Patch Set 2 : rebase #

Created: 3 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -223 lines)			Patch
M	chrome/browser/chromeos/drive/file_system.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/copy_operation.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/create_file_operation.h	View		3 chunks	+5 lines, -30 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/create_file_operation.cc	View		4 chunks	+53 lines, -175 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/create_file_operation_unittest.cc	View		3 chunks	+31 lines, -7 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/drive/file_system/open_file_operation.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Trybot results: cros_daisy linux_chromeos cros_x86 linux_chromeos_clang

Commit queue not available (can’t edit this change).

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hashimoto

https://codereview.chromium.org/137423010/diff/20001/chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc File chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc (right): https://codereview.chromium.org/137423010/diff/20001/chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc#newcode43 chrome/browser/chromeos/drive/file_system/get_file_for_saving_operation_unittest.cc:43: if (!quit_closure_.is_null()) This null check is needed because CreateFileOpreration ...

3 years, 7 months ago (2014-01-30 04:25:50 UTC) #1

hashimoto

3 years, 7 months ago (2014-01-31 05:50:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r248138 (presubmit successful).

Expand Messages | Collapse Messages

Issue 137423010: drive: Support offline file creation (Closed)

Description

Patch Set 1 : #

Patch Set 2 : rebase #

Messages