Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1406)

Unified Diff: content/browser/indexed_db/leveldb/leveldb_database.cc

Issue 137423006: IndexedDB: fsync after transactions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/indexed_db/leveldb/leveldb_database.cc
diff --git a/content/browser/indexed_db/leveldb/leveldb_database.cc b/content/browser/indexed_db/leveldb/leveldb_database.cc
index 7780336f8275fe248eac682bef4de71c264444dc..dad66fe26990e0acaf764e8e2ccb0a79dc2b0e18 100644
--- a/content/browser/indexed_db/leveldb/leveldb_database.cc
+++ b/content/browser/indexed_db/leveldb/leveldb_database.cc
@@ -34,14 +34,16 @@ namespace content {
// data hit disk, but drastically impacts throughput when the filesystem is
// busy with background compactions. Not syncing trades off reliability for
// performance. Note that background compactions which move data from the
-// log to SSTs are still done with reliable writes.
+// log to SSTs are always done with reliable writes.
//
// Sync writes are necessary on Windows for quota calculations; POSIX
// calculates file sizes correctly even when not synced to disk.
#if defined(OS_WIN)
static const bool kSyncWrites = true;
#else
-static const bool kSyncWrites = false;
+// Set _back_ to true in attempt to fix corruption increase on CrOS devices.
jsbell 2014/01/27 21:18:22 Can you make this a TODO to either remove the #if
dgrogan 2014/01/27 21:22:05 Done.
+// See http://crbug.com/338385.
+static const bool kSyncWrites = true;
#endif
static leveldb::Slice MakeSlice(const StringPiece& s) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698