Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 137423006: IndexedDB: fsync after transactions. (Closed)

Created:
6 years, 11 months ago by dgrogan
Modified:
6 years, 11 months ago
Reviewers:
jsbell
CC:
chromium-reviews, jsbell, jam, alecflett, joi+watch-content_chromium.org, darin-cc_chromium.org, cmumford, dgrogan
Visibility:
Public.

Description

IndexedDB: fsync after transactions. IndexedDB corruption rose, only on CrOS, in the 32 release. Included in that release was a change that stopped calling fsync after transactions commit. It is the only IDB change that possibly sacrficed stability to get better performance. So: revert it and see if corruption jumps back to 31 levels. BUG=299831, 338385 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247351

Patch Set 1 #

Total comments: 2

Patch Set 2 : changed to TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M content/browser/indexed_db/leveldb/leveldb_database.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dgrogan
Josh, could you review this?
6 years, 11 months ago (2014-01-27 21:16:39 UTC) #1
jsbell
lgtm https://codereview.chromium.org/137423006/diff/1/content/browser/indexed_db/leveldb/leveldb_database.cc File content/browser/indexed_db/leveldb/leveldb_database.cc (right): https://codereview.chromium.org/137423006/diff/1/content/browser/indexed_db/leveldb/leveldb_database.cc#newcode44 content/browser/indexed_db/leveldb/leveldb_database.cc:44: // Set _back_ to true in attempt to ...
6 years, 11 months ago (2014-01-27 21:18:21 UTC) #2
dgrogan
https://codereview.chromium.org/137423006/diff/1/content/browser/indexed_db/leveldb/leveldb_database.cc File content/browser/indexed_db/leveldb/leveldb_database.cc (right): https://codereview.chromium.org/137423006/diff/1/content/browser/indexed_db/leveldb/leveldb_database.cc#newcode44 content/browser/indexed_db/leveldb/leveldb_database.cc:44: // Set _back_ to true in attempt to fix ...
6 years, 11 months ago (2014-01-27 21:22:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/137423006/20001
6 years, 11 months ago (2014-01-27 21:23:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dgrogan@chromium.org/137423006/20001
6 years, 11 months ago (2014-01-28 00:05:02 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-28 00:24:36 UTC) #6
Message was sent while issue was closed.
Change committed as 247351

Powered by Google App Engine
This is Rietveld 408576698