Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1374203002: [heap] No leakage of incremental-marking.h outside of heap. (Closed)

Created:
5 years, 2 months ago by Michael Starzinger
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] No leakage of incremental-marking.h outside of heap. This prevents the internal incremental-marking.h to be usable outisde of the "heap" directory. The logic inside that component is only useful within the GC and is now properly encapsulated. R=hpayer@chromium.org Committed: https://crrev.com/ddafe2c4940ae20a7c925047d27b54be234cada4 Cr-Commit-Position: refs/heads/master@{#31010}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -72 lines) Patch
M include/v8.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/api.cc View 1 chunk +3 lines, -24 lines 0 comments Download
M src/heap/heap.h View 4 chunks +7 lines, -13 lines 0 comments Download
M src/heap/heap.cc View 5 chunks +33 lines, -27 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +9 lines, -0 lines 0 comments Download
M src/heap/incremental-marking.cc View 2 chunks +29 lines, -0 lines 0 comments Download
M src/heap/incremental-marking-job.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/heap/memory-reducer.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-heap.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 2 months ago (2015-09-29 10:46:05 UTC) #1
Hannes Payer (out of office)
lgtm
5 years, 2 months ago (2015-09-29 16:56:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374203002/1
5 years, 2 months ago (2015-09-29 16:56:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 16:59:09 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 16:59:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ddafe2c4940ae20a7c925047d27b54be234cada4
Cr-Commit-Position: refs/heads/master@{#31010}

Powered by Google App Engine
This is Rietveld 408576698