Issue 1374193002: Web Animations: Don't participate in grouping when start time is set

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1374193002: Web Animations: Don't participate in grouping when start time is set (Closed)

Created:
5 years, 2 months ago by dstockwell

Modified:
5 years, 2 months ago

Reviewers:
alancutter (OOO until 2018)

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@2490

Target Ref:
refs/pending/branch-heads/2490

Project:
chromium

Visibility:
Public.

More Reviews

Description

Web Animations: Don't participate in grouping when start time is set After a recent change[1] cc started sending back animation specified start times when present. This was inadvertently applied to animations in the same compositor group (started in the same frame), which could cause animations to receive an inappropriate start time. To avoid this regression, animations with a specified start time are labeled with a distinct compositor group as they do not participate in grouping. [1] https://chromium.googlesource.com/chromium/src/+/33c2aaa27b1ab502cfa08b7d271b58b8b485b5cc TBR=alancutter BUG=528291 NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1341673002 git-svn-id: svn://svn.chromium.org/blink/trunk@202617 bbb929c8-8fbe-4397-9dbb-9b2b20218538 (cherry picked from commit 8b92cba227fb440d25182d0ee71825541cf9f350) Committed: https://chromium.googlesource.com/chromium/src/+/c47557a1c172825a30f2974c71641fcf540ccc20

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -3 lines)			Patch
	A	third_party/WebKit/LayoutTests/web-animations-api/start-time-grouping.html	View		1 chunk	+50 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/animation/CompositorPendingAnimations.cpp	View		1 chunk	+5 lines, -3 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

dstockwell

5 years, 2 months ago (2015-09-29 10:42:41 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c47557a1c172825a30f2974c71641fcf540ccc20.

Expand Messages | Collapse Messages