Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1374163002: [heap] Reland Remove retry space from AllocateRaw. (Closed)

Created:
5 years, 2 months ago by Hannes Payer (out of office)
Modified:
5 years, 2 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Reland Remove retry space from AllocateRaw. BUG= Committed: https://crrev.com/ce28d019eb28f7d91e554ffc1d5a209d3f332ee1 Cr-Commit-Position: refs/heads/master@{#30998}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -301 lines) Patch
M src/heap/heap.h View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 26 chunks +37 lines, -90 lines 0 comments Download
M src/heap/heap-inl.h View 4 chunks +8 lines, -14 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/test-heap.cc View 2 chunks +0 lines, -111 lines 0 comments Download
M test/cctest/test-strings.cc View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/test-unboxed-doubles.cc View 1 2 chunks +0 lines, -84 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Starzinger
LGTM (rubber-stamped, sorry Mario, your review is in another CL).
5 years, 2 months ago (2015-09-29 08:46:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1374163002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1374163002/20001
5 years, 2 months ago (2015-09-29 08:46:43 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-29 09:08:15 UTC) #5
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 09:08:34 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ce28d019eb28f7d91e554ffc1d5a209d3f332ee1
Cr-Commit-Position: refs/heads/master@{#30998}

Powered by Google App Engine
This is Rietveld 408576698