Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 1374113006: Use the new Base64 support from dart:convert in Observatory. (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use the new Base64 support from dart:convert in Observatory. R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/816e665ae10800d1306d02affadda8b1f234396a

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -81 lines) Patch
D runtime/observatory/lib/base64.dart View 1 chunk +0 lines, -69 lines 0 comments Download
M runtime/observatory/lib/service.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/get_object_rpc_test.dart View 1 7 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 1 month ago (2015-11-13 22:33:41 UTC) #2
Cutch
lgtm
5 years, 1 month ago (2015-11-13 22:42:47 UTC) #3
rmacnak
5 years, 1 month ago (2015-11-13 23:36:31 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
816e665ae10800d1306d02affadda8b1f234396a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698