Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.h

Issue 1374053002: Remove AboutToNavigateRenderFrame, issue custom notification for DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased, win test fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/render_frame_devtools_agent_host.h
diff --git a/content/browser/devtools/render_frame_devtools_agent_host.h b/content/browser/devtools/render_frame_devtools_agent_host.h
index bc4b436b9fe650e1a6a5ce8440d6495fadc98803..35c1f1b318ef78d0016f98b21a14b011552f3dfa 100644
--- a/content/browser/devtools/render_frame_devtools_agent_host.h
+++ b/content/browser/devtools/render_frame_devtools_agent_host.h
@@ -51,6 +51,8 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
static void OnCancelPendingNavigation(RenderFrameHost* pending,
RenderFrameHost* current);
+ static void OnBeforeNavigation(RenderFrameHost* current,
+ RenderFrameHost* pending);
void SynchronousSwapCompositorFrame(
const cc::CompositorFrameMetadata& frame_metadata);
@@ -86,8 +88,6 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
void InspectElement(int x, int y) override;
// WebContentsObserver overrides.
- void AboutToNavigateRenderFrame(RenderFrameHost* old_host,
- RenderFrameHost* new_host) override;
void RenderFrameHostChanged(RenderFrameHost* old_host,
RenderFrameHost* new_host) override;
void FrameDeleted(RenderFrameHost* rfh) override;
@@ -109,6 +109,9 @@ class CONTENT_EXPORT RenderFrameDevToolsAgentHost
const base::string16& error_description,
bool was_ignored_by_handler) override;
+ void AboutToNavigateRenderFrame(RenderFrameHost* old_host,
+ RenderFrameHost* new_host);
+
void SetPending(RenderFrameHostImpl* host);
void CommitPending();
void DiscardPending();

Powered by Google App Engine
This is Rietveld 408576698