Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Side by Side Diff: content/browser/web_contents/web_contents_impl.cc

Issue 1374053002: Remove AboutToNavigateRenderFrame, issue custom notification for DevTools. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased, win test fix Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/web_contents/web_contents_impl.h" 5 #include "content/browser/web_contents/web_contents_impl.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/command_line.h" 9 #include "base/command_line.h"
10 #include "base/lazy_instance.h" 10 #include "base/lazy_instance.h"
(...skipping 2850 matching lines...) Expand 10 before | Expand all | Expand 10 after
2861 observers_, 2861 observers_,
2862 DidFailLoad(render_frame_host, url, error_code, error_description, 2862 DidFailLoad(render_frame_host, url, error_code, error_description,
2863 was_ignored_by_handler)); 2863 was_ignored_by_handler));
2864 } 2864 }
2865 2865
2866 void WebContentsImpl::NotifyChangedNavigationState( 2866 void WebContentsImpl::NotifyChangedNavigationState(
2867 InvalidateTypes changed_flags) { 2867 InvalidateTypes changed_flags) {
2868 NotifyNavigationStateChanged(changed_flags); 2868 NotifyNavigationStateChanged(changed_flags);
2869 } 2869 }
2870 2870
2871 void WebContentsImpl::AboutToNavigateRenderFrame(
2872 RenderFrameHostImpl* old_host,
2873 RenderFrameHostImpl* new_host) {
2874 // Notify observers that we will navigate in this RenderFrame.
2875 FOR_EACH_OBSERVER(
2876 WebContentsObserver,
2877 observers_,
2878 AboutToNavigateRenderFrame(old_host, new_host));
2879 }
2880
2881 void WebContentsImpl::DidStartNavigationToPendingEntry( 2871 void WebContentsImpl::DidStartNavigationToPendingEntry(
2882 const GURL& url, 2872 const GURL& url,
2883 NavigationController::ReloadType reload_type) { 2873 NavigationController::ReloadType reload_type) {
2884 // Notify observers about navigation. 2874 // Notify observers about navigation.
2885 FOR_EACH_OBSERVER( 2875 FOR_EACH_OBSERVER(
2886 WebContentsObserver, 2876 WebContentsObserver,
2887 observers_, 2877 observers_,
2888 DidStartNavigationToPendingEntry(url, reload_type)); 2878 DidStartNavigationToPendingEntry(url, reload_type));
2889 } 2879 }
2890 2880
(...skipping 1758 matching lines...) Expand 10 before | Expand all | Expand 10 after
4649 return NULL; 4639 return NULL;
4650 } 4640 }
4651 4641
4652 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) { 4642 void WebContentsImpl::SetForceDisableOverscrollContent(bool force_disable) {
4653 force_disable_overscroll_content_ = force_disable; 4643 force_disable_overscroll_content_ = force_disable;
4654 if (view_) 4644 if (view_)
4655 view_->SetOverscrollControllerEnabled(CanOverscrollContent()); 4645 view_->SetOverscrollControllerEnabled(CanOverscrollContent());
4656 } 4646 }
4657 4647
4658 } // namespace content 4648 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/web_contents/web_contents_impl.h ('k') | content/public/browser/web_contents_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698