Blacklist MSAA for GPU Raster on Intel GPUs

Blacklist MSAA for GPU Raster on Intel GPUs

Intel GPUs have unacceptable performance for GPU raster when MSAA is
enabled. This has been tested on recent Intel GPUs on CrOS, Mac, and
Windows. Given this we’re adding a workaround for Intel GPUs which will
disable MSAA for GPU raster.

We don’t want to impact WebGL, so this workaround specifically targets
non-WebGL contexts.

I’ve updated FeatureInfo’s Initialize function to accept the context
type, which allows us to customize features based on webgl/non-webgl.

I’ve also changed the secondary version of Initialize, which takes no
arguments, to be InitializeForTesting, as this function is only called
in tests.

BUG=527565
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe
Cr-Commit-Position: refs/heads/master@{#351904}

[ericrk, 2015-09-30 23:26:19]

ericrk@chromium.org changed reviewers:
+ zmo@google.com

[ericrk, 2015-09-30 23:26:19]

Hi Mo,

Let me know if this approach (modifying FeatureInfo) seems reasonable - we could
also pull this out of FeatureInfo and handle it at each call-site where we check
these features in the command decoder.

[ericrk, 2015-09-30 23:26:48]

ericrk@chromium.org changed reviewers:
+ zmo@chromium.org
- zmo@google.com

[Zhenyao Mo, 2015-09-30 23:50:06]

On 2015/09/30 23:26:19, ericrk wrote:
> Hi Mo,
> 
> Let me know if this approach (modifying FeatureInfo) seems reasonable - we
could
> also pull this out of FeatureInfo and handle it at each call-site where we
check
> these features in the command decoder.

Mostly look good with some minor fixes.

[Zhenyao Mo, 2015-09-30 23:50:13]

https://chromiumcodereview.appspot.com/1374043005/diff/60001/gpu/command_buff...
File gpu/command_buffer/service/feature_info.cc (right):

https://chromiumcodereview.appspot.com/1374043005/diff/60001/gpu/command_buff...
gpu/command_buffer/service/feature_info.cc:1129: if
(workarounds_.disable_msaa_on_non_webgl_contexts) {
This is inconsistent with the rest of the code.  Basically you should check this
workaround where you set these flags earlier in this function, not resetting
them in the end.

https://chromiumcodereview.appspot.com/1374043005/diff/60001/gpu/command_buff...
File gpu/command_buffer/service/feature_info.h (right):

https://chromiumcodereview.appspot.com/1374043005/diff/60001/gpu/command_buff...
gpu/command_buffer/service/feature_info.h:168: ContextType context_type_;
If you define this here, then remove the one in gles2_cmd_decoder. You will need
to expose with a getter function here, so decoder can query it.

https://chromiumcodereview.appspot.com/1374043005/diff/60001/gpu/config/gpu_d...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://chromiumcodereview.appspot.com/1374043005/diff/60001/gpu/config/gpu_d...
gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.25",
Update version to 8.26

https://chromiumcodereview.appspot.com/1374043005/diff/60001/gpu/config/gpu_d...
File gpu/config/gpu_driver_bug_workaround_type.h (right):

https://chromiumcodereview.appspot.com/1374043005/diff/60001/gpu/config/gpu_d...
gpu/config/gpu_driver_bug_workaround_type.h:141:
GPU_OP(DISABLE_MSAA_ON_NON_WEBGL_CONTEXTS,                 \
alphabetic order

[Zhenyao Mo, 2015-09-30 23:51:37]

https://chromiumcodereview.appspot.com/1374043005/diff/60001/gpu/command_buff...
File gpu/command_buffer/service/feature_info.h (right):

https://chromiumcodereview.appspot.com/1374043005/diff/60001/gpu/command_buff...
gpu/command_buffer/service/feature_info.h:168: ContextType context_type_;
On 2015/09/30 23:50:13, Zhenyao Mo wrote:
> If you define this here, then remove the one in gles2_cmd_decoder. You will
need
> to expose with a getter function here, so decoder can query it.

Actually you can also remove it from the context_group.  So we have consistency
in the information and much easier to maintain.

[ericrk, 2015-10-01 17:08:45]

Patchset #5 (id:80001) has been deleted

[ericrk, 2015-10-01 17:13:11]

Thanks for the feedback!

https://codereview.chromium.org/1374043005/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/1374043005/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.cc:1129: if
(workarounds_.disable_msaa_on_non_webgl_contexts) {
On 2015/09/30 23:50:12, Zhenyao Mo wrote:
> This is inconsistent with the rest of the code.  Basically you should check
this
> workaround where you set these flags earlier in this function, not resetting
> them in the end.

yup, good point - restructured this.

https://codereview.chromium.org/1374043005/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/feature_info.h (right):

https://codereview.chromium.org/1374043005/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/feature_info.h:168: ContextType context_type_;
On 2015/09/30 23:51:37, Zhenyao Mo wrote:
> On 2015/09/30 23:50:13, Zhenyao Mo wrote:
> > If you define this here, then remove the one in gles2_cmd_decoder. You will
> need
> > to expose with a getter function here, so decoder can query it.
> 
> Actually you can also remove it from the context_group.  So we have
consistency
> in the information and much easier to maintain.

Done.

https://codereview.chromium.org/1374043005/diff/60001/gpu/config/gpu_driver_b...
File gpu/config/gpu_driver_bug_workaround_type.h (right):

https://codereview.chromium.org/1374043005/diff/60001/gpu/config/gpu_driver_b...
gpu/config/gpu_driver_bug_workaround_type.h:141:
GPU_OP(DISABLE_MSAA_ON_NON_WEBGL_CONTEXTS,                 \
On 2015/09/30 23:50:13, Zhenyao Mo wrote:
> alphabetic order

Done.

[ericrk, 2015-10-01 17:33:10]

Patchset #6 (id:120001) has been deleted

[Zhenyao Mo, 2015-10-01 19:55:30]

Beautiful CL.

LGTM with the json file version updated.

https://codereview.chromium.org/1374043005/diff/140001/gpu/config/gpu_driver_...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/1374043005/diff/140001/gpu/config/gpu_driver_...
gpu/config/gpu_driver_bug_list_json.cc:1555: ]
You still haven't updated the version at the beginning of this file.

[ericrk, 2015-10-01 20:33:05]

Patchset #7 (id:160001) has been deleted

[ericrk, 2015-10-01 20:58:48]

https://codereview.chromium.org/1374043005/diff/140001/gpu/config/gpu_driver_...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/1374043005/diff/140001/gpu/config/gpu_driver_...
gpu/config/gpu_driver_bug_list_json.cc:1555: ]
On 2015/10/01 19:55:30, Zhenyao Mo wrote:
> You still haven't updated the version at the beginning of this file.

oops, missed that - done.

[ericrk, 2015-10-01 20:58:51]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2015-10-01 20:58:52]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1374043005/#ps180001
(title: "version #")

[commit-bot: I haz the power, 2015-10-01 21:00:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1374043005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1374043005/180001

[commit-bot: I haz the power, 2015-10-01 21:06:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 21:06:21]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[ericrk, 2015-10-01 21:10:14]

Patchset #8 (id:200001) has been deleted

[ericrk, 2015-10-01 21:10:19]

The CQ bit was checked by ericrk@chromium.org

[ericrk, 2015-10-01 21:10:20]

The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org
Link to the patchset: https://codereview.chromium.org/1374043005/#ps180001
(title: "version #")

[commit-bot: I haz the power, 2015-10-01 21:11:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1374043005/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1374043005/180001

[commit-bot: I haz the power, 2015-10-01 22:19:07]

Committed patchset #7 (id:180001)

[commit-bot: I haz the power, 2015-10-01 22:20:13]

Patchset 7 (id:??) landed as
https://crrev.com/ed27437d3a0a58534dd6cb877b18d2d60d1d21fe
Cr-Commit-Position: refs/heads/master@{#351904}