Adding a type vector to replace type cells.

src/compiler.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 85 matching lines @@
   }
   void MarkAsGlobal() {
     ASSERT(!is_lazy());
     flags_ |= IsGlobal::encode(true);
   }
   void set_parameter_count(int parameter_count) {
     ASSERT(IsStub());
     parameter_count_ = parameter_count;
   }
 
+  void ProcessFeedbackSlots();
+  int slot_count() { return function()->slot_count(); }
+
   void set_this_has_uses(bool has_no_uses) {
     this_has_uses_ = has_no_uses;
   }
   bool this_has_uses() {
     return this_has_uses_;
   }
   void SetLanguageMode(LanguageMode language_mode) {
     ASSERT(this->language_mode() == CLASSIC_MODE ||
            this->language_mode() == language_mode ||
            language_mode == EXTENDED_MODE);
@@ skipping 509 matching lines @@
                                                   int line_offset,
                                                   int column_offset,
                                                   bool is_shared_cross_origin,
                                                   Handle<Context> context,
                                                   v8::Extension* extension,
                                                   ScriptDataImpl* pre_data,
                                                   Handle<Object> script_data,
                                                   NativesFlag is_natives_code);
 
   // Create a shared function info object (the code may be lazily compiled).
-  static Handle<SharedFunctionInfo> BuildFunctionInfo(FunctionLiteral* node,
-                                                      Handle<Script> script);
+  static Handle<SharedFunctionInfo> BuildFunctionInfo(
+      FunctionLiteral* node,
+      Handle<Script> script,
+      bool process_feedback = true);

[Benedikt Meurer, 2014/02/04 08:53:50]

This bool parameter is really confusing. If we really need it here to make
things work, we should consider fixing our pipeline first, i.e. split this
method into two methods.

[mvstanton, 2014/02/04 13:03:27]

Took some effort but I finally figured out another way.
The real chokepoint for this work is
CompilationInfo::SetScope(), because when the scope is applied, the deferred
work can be performed. However because this is a pile of work that has to be
done, Danno noticed this was bad because "SetScope" implies a simple setter
rather than a method that does work. So I renamed the method to
InitializeScope(), indicating with a comment that some deferred work may be
performed.

In this way I don't need to even mention feedback slots in the public interface
of CompilationInfo.

 
   enum ConcurrencyMode { NOT_CONCURRENT, CONCURRENT };
 
   // Generate and return optimized code or start a concurrent optimization job.
   // In the latter case, return the InOptimizationQueue builtin.  On failure,
   // return the empty handle.
   static Handle<Code> GetOptimizedCode(
       Handle<JSFunction> function,
       Handle<Code> current_code,
       ConcurrencyMode mode,
@@ skipping 29 matching lines @@
   unsigned info_zone_start_allocation_size_;
   ElapsedTimer timer_;
 
   DISALLOW_COPY_AND_ASSIGN(CompilationPhase);
 };
 
 
 } }  // namespace v8::internal
 
 #endif  // V8_COMPILER_H_