Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Side by Side Diff: src/x64/debug-x64.cc

Issue 137403009: Adding a type vector to replace type cells. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed feedback. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
254 // -- rdi : function 254 // -- rdi : function
255 // ----------------------------------- 255 // -----------------------------------
256 Generate_DebugBreakCallHelper(masm, rdi.bit(), 0, false); 256 Generate_DebugBreakCallHelper(masm, rdi.bit(), 0, false);
257 } 257 }
258 258
259 259
260 void Debug::GenerateCallFunctionStubRecordDebugBreak(MacroAssembler* masm) { 260 void Debug::GenerateCallFunctionStubRecordDebugBreak(MacroAssembler* masm) {
261 // Register state for CallFunctionStub (from code-stubs-x64.cc). 261 // Register state for CallFunctionStub (from code-stubs-x64.cc).
262 // ----------- S t a t e ------------- 262 // ----------- S t a t e -------------
263 // -- rdi : function 263 // -- rdi : function
264 // -- rbx: cache cell for call target 264 // -- rbx: feedback array
265 // -- rdx: slot in feedback array
265 // ----------------------------------- 266 // -----------------------------------
266 Generate_DebugBreakCallHelper(masm, rbx.bit() | rdi.bit(), 0, false); 267 Generate_DebugBreakCallHelper(masm, rbx.bit() | rdx.bit() | rdi.bit(),
268 0, false);
267 } 269 }
268 270
269 271
270 void Debug::GenerateCallConstructStubDebugBreak(MacroAssembler* masm) { 272 void Debug::GenerateCallConstructStubDebugBreak(MacroAssembler* masm) {
271 // Register state for CallConstructStub (from code-stubs-x64.cc). 273 // Register state for CallConstructStub (from code-stubs-x64.cc).
272 // rax is the actual number of arguments not encoded as a smi, see comment 274 // rax is the actual number of arguments not encoded as a smi, see comment
273 // above IC call. 275 // above IC call.
274 // ----------- S t a t e ------------- 276 // ----------- S t a t e -------------
275 // -- rax: number of arguments 277 // -- rax: number of arguments
276 // ----------------------------------- 278 // -----------------------------------
277 // The number of arguments in rax is not smi encoded. 279 // The number of arguments in rax is not smi encoded.
278 Generate_DebugBreakCallHelper(masm, rdi.bit(), rax.bit(), false); 280 Generate_DebugBreakCallHelper(masm, rdi.bit(), rax.bit(), false);
279 } 281 }
280 282
281 283
282 void Debug::GenerateCallConstructStubRecordDebugBreak(MacroAssembler* masm) { 284 void Debug::GenerateCallConstructStubRecordDebugBreak(MacroAssembler* masm) {
283 // Register state for CallConstructStub (from code-stubs-x64.cc). 285 // Register state for CallConstructStub (from code-stubs-x64.cc).
284 // rax is the actual number of arguments not encoded as a smi, see comment 286 // rax is the actual number of arguments not encoded as a smi, see comment
285 // above IC call. 287 // above IC call.
286 // ----------- S t a t e ------------- 288 // ----------- S t a t e -------------
287 // -- rax: number of arguments 289 // -- rax: number of arguments
288 // -- rbx: cache cell for call target 290 // -- rbx: feedback array
291 // -- rdx: feedback slot (smi)
289 // ----------------------------------- 292 // -----------------------------------
290 // The number of arguments in rax is not smi encoded. 293 // The number of arguments in rax is not smi encoded.
291 Generate_DebugBreakCallHelper(masm, rbx.bit() | rdi.bit(), rax.bit(), false); 294 Generate_DebugBreakCallHelper(masm, rbx.bit() | rdx.bit() | rdi.bit(),
295 rax.bit(), false);
292 } 296 }
293 297
294 298
295 void Debug::GenerateSlot(MacroAssembler* masm) { 299 void Debug::GenerateSlot(MacroAssembler* masm) {
296 // Generate enough nop's to make space for a call instruction. 300 // Generate enough nop's to make space for a call instruction.
297 Label check_codesize; 301 Label check_codesize;
298 __ bind(&check_codesize); 302 __ bind(&check_codesize);
299 __ RecordDebugBreakSlot(); 303 __ RecordDebugBreakSlot();
300 __ Nop(Assembler::kDebugBreakSlotLength); 304 __ Nop(Assembler::kDebugBreakSlotLength);
301 ASSERT_EQ(Assembler::kDebugBreakSlotLength, 305 ASSERT_EQ(Assembler::kDebugBreakSlotLength,
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 346
343 const bool Debug::kFrameDropperSupported = true; 347 const bool Debug::kFrameDropperSupported = true;
344 348
345 #undef __ 349 #undef __
346 350
347 #endif // ENABLE_DEBUGGER_SUPPORT 351 #endif // ENABLE_DEBUGGER_SUPPORT
348 352
349 } } // namespace v8::internal 353 } } // namespace v8::internal
350 354
351 #endif // V8_TARGET_ARCH_X64 355 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/full-codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698