Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: src/ia32/debug-ia32.cc

Issue 137403009: Adding a type vector to replace type cells. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed feedback. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 262 matching lines...) Expand 10 before | Expand all | Expand 10 after
273 // ----------- S t a t e ------------- 273 // ----------- S t a t e -------------
274 // -- edi: function 274 // -- edi: function
275 // ----------------------------------- 275 // -----------------------------------
276 Generate_DebugBreakCallHelper(masm, edi.bit(), 0, false); 276 Generate_DebugBreakCallHelper(masm, edi.bit(), 0, false);
277 } 277 }
278 278
279 279
280 void Debug::GenerateCallFunctionStubRecordDebugBreak(MacroAssembler* masm) { 280 void Debug::GenerateCallFunctionStubRecordDebugBreak(MacroAssembler* masm) {
281 // Register state for CallFunctionStub (from code-stubs-ia32.cc). 281 // Register state for CallFunctionStub (from code-stubs-ia32.cc).
282 // ----------- S t a t e ------------- 282 // ----------- S t a t e -------------
283 // -- ebx: cache cell for call target 283 // -- ebx: feedback array
284 // -- edx: slot in feedback array
284 // -- edi: function 285 // -- edi: function
285 // ----------------------------------- 286 // -----------------------------------
286 Generate_DebugBreakCallHelper(masm, ebx.bit() | edi.bit(), 0, false); 287 Generate_DebugBreakCallHelper(masm, ebx.bit() | edx.bit() | edi.bit(),
288 0, false);
287 } 289 }
288 290
289 291
290 void Debug::GenerateCallConstructStubDebugBreak(MacroAssembler* masm) { 292 void Debug::GenerateCallConstructStubDebugBreak(MacroAssembler* masm) {
291 // Register state for CallConstructStub (from code-stubs-ia32.cc). 293 // Register state for CallConstructStub (from code-stubs-ia32.cc).
292 // eax is the actual number of arguments not encoded as a smi see comment 294 // eax is the actual number of arguments not encoded as a smi see comment
293 // above IC call. 295 // above IC call.
294 // ----------- S t a t e ------------- 296 // ----------- S t a t e -------------
295 // -- eax: number of arguments (not smi) 297 // -- eax: number of arguments (not smi)
296 // -- edi: constructor function 298 // -- edi: constructor function
297 // ----------------------------------- 299 // -----------------------------------
298 // The number of arguments in eax is not smi encoded. 300 // The number of arguments in eax is not smi encoded.
299 Generate_DebugBreakCallHelper(masm, edi.bit(), eax.bit(), false); 301 Generate_DebugBreakCallHelper(masm, edi.bit(), eax.bit(), false);
300 } 302 }
301 303
302 304
303 void Debug::GenerateCallConstructStubRecordDebugBreak(MacroAssembler* masm) { 305 void Debug::GenerateCallConstructStubRecordDebugBreak(MacroAssembler* masm) {
304 // Register state for CallConstructStub (from code-stubs-ia32.cc). 306 // Register state for CallConstructStub (from code-stubs-ia32.cc).
305 // eax is the actual number of arguments not encoded as a smi see comment 307 // eax is the actual number of arguments not encoded as a smi see comment
306 // above IC call. 308 // above IC call.
307 // ----------- S t a t e ------------- 309 // ----------- S t a t e -------------
308 // -- eax: number of arguments (not smi) 310 // -- eax: number of arguments (not smi)
309 // -- ebx: cache cell for call target 311 // -- ebx: feedback array
312 // -- edx: feedback slot (smi)
310 // -- edi: constructor function 313 // -- edi: constructor function
311 // ----------------------------------- 314 // -----------------------------------
312 // The number of arguments in eax is not smi encoded. 315 // The number of arguments in eax is not smi encoded.
313 Generate_DebugBreakCallHelper(masm, ebx.bit() | edi.bit(), eax.bit(), false); 316 Generate_DebugBreakCallHelper(masm, ebx.bit() | edx.bit() | edi.bit(),
317 eax.bit(), false);
314 } 318 }
315 319
316 320
317 void Debug::GenerateSlot(MacroAssembler* masm) { 321 void Debug::GenerateSlot(MacroAssembler* masm) {
318 // Generate enough nop's to make space for a call instruction. 322 // Generate enough nop's to make space for a call instruction.
319 Label check_codesize; 323 Label check_codesize;
320 __ bind(&check_codesize); 324 __ bind(&check_codesize);
321 __ RecordDebugBreakSlot(); 325 __ RecordDebugBreakSlot();
322 __ Nop(Assembler::kDebugBreakSlotLength); 326 __ Nop(Assembler::kDebugBreakSlotLength);
323 ASSERT_EQ(Assembler::kDebugBreakSlotLength, 327 ASSERT_EQ(Assembler::kDebugBreakSlotLength,
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
363 367
364 const bool Debug::kFrameDropperSupported = true; 368 const bool Debug::kFrameDropperSupported = true;
365 369
366 #undef __ 370 #undef __
367 371
368 #endif // ENABLE_DEBUGGER_SUPPORT 372 #endif // ENABLE_DEBUGGER_SUPPORT
369 373
370 } } // namespace v8::internal 374 } } // namespace v8::internal
371 375
372 #endif // V8_TARGET_ARCH_IA32 376 #endif // V8_TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « src/ia32/code-stubs-ia32.cc ('k') | src/ia32/full-codegen-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698