Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 137403005: Remove some code inside USE_AURA and OS_WIN ifdefs. (Closed)

Created:
6 years, 11 months ago by jam
Modified:
6 years, 11 months ago
Reviewers:
scottmg
CC:
chromium-reviews, yusukes+watch_chromium.org, yoshiki+watch_chromium.org, dcheng, sievers+watch_chromium.org, yukishiino+watch_chromium.org, dmazzoni+watch_chromium.org, miu+watch_chromium.org, joi+watch-content_chromium.org, aboxhall+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, jennb, penghuang+watch_chromium.org, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, jianli, piman+watch_chromium.org, plundblad+watch_chromium.org, tfarina, Dmitry Titov, dtseng+watch_chromium.org, danakj+watch_chromium.org, James Su
Visibility:
Public.

Description

Remove some code inside USE_AURA and OS_WIN ifdefs in content. I also removed the _win.cc files inside content. BUG=330735 R=scottmg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244768

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -5833 lines) Patch
M chrome/browser/ui/views/apps/native_app_window_views.cc View 1 chunk +0 lines, -53 lines 0 comments Download
M chrome/browser/ui/views/panels/panel_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/panels/panel_view.cc View 3 chunks +0 lines, -29 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_manager_win.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M content/browser/accessibility/browser_accessibility_win_unittest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/browser_plugin/browser_plugin_host_browsertest.cc View 2 chunks +2 lines, -6 lines 0 comments Download
M content/browser/frame_host/interstitial_page_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/interstitial_page_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.h View 2 chunks +1 line, -8 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_child_frame.cc View 3 chunks +1 line, -11 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.h View 1 chunk +1 line, -5 lines 0 comments Download
M content/browser/frame_host/render_widget_host_view_guest.cc View 1 chunk +1 line, -6 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/media/webrtc_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_browsertest.cc View 2 chunks +2 lines, -8 lines 0 comments Download
D content/browser/renderer_host/render_widget_host_view_win.h View 1 1 chunk +0 lines, -610 lines 0 comments Download
D content/browser/renderer_host/render_widget_host_view_win.cc View 1 1 chunk +0 lines, -3222 lines 1 comment Download
D content/browser/web_contents/web_contents_drag_win.h View 1 1 chunk +0 lines, -122 lines 0 comments Download
D content/browser/web_contents/web_contents_drag_win.cc View 1 1 chunk +0 lines, -443 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 4 chunks +3 lines, -14 lines 0 comments Download
D content/browser/web_contents/web_contents_view_win.h View 1 1 chunk +0 lines, -147 lines 0 comments Download
D content/browser/web_contents/web_contents_view_win.cc View 1 1 chunk +0 lines, -465 lines 0 comments Download
D content/browser/web_contents/web_drag_dest_win.h View 1 1 chunk +0 lines, -89 lines 0 comments Download
D content/browser/web_contents/web_drag_dest_win.cc View 1 1 chunk +0 lines, -286 lines 0 comments Download
D content/browser/web_contents/web_drag_source_win.h View 1 1 chunk +0 lines, -79 lines 0 comments Download
D content/browser/web_contents/web_drag_source_win.cc View 1 1 chunk +0 lines, -130 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/child/npapi/webplugin_delegate_impl_win.cc View 6 chunks +1 line, -10 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 6 chunks +3 lines, -28 lines 0 comments Download
M content/content_child.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M content/plugin/plugin_thread.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/port/browser/render_widget_host_view_port.h View 1 chunk +1 line, -5 lines 0 comments Download
M content/public/browser/render_widget_host_view.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/layouttest_support.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/test/test_render_view_host.h View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M content/test/test_render_view_host.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jam
6 years, 11 months ago (2014-01-14 15:48:45 UTC) #1
scottmg
I think we said we were waiting until stable pushed at 100% (today?), but otherwise ...
6 years, 11 months ago (2014-01-14 17:28:32 UTC) #2
jam
On 2014/01/14 17:28:32, scottmg wrote: > I think we said we were waiting until stable ...
6 years, 11 months ago (2014-01-14 17:59:56 UTC) #3
scottmg
6 years, 11 months ago (2014-01-14 18:06:59 UTC) #4
Awesome, nuke it.


On Tue, Jan 14, 2014 at 9:59 AM, <jam@chromium.org> wrote:

> On 2014/01/14 17:28:32, scottmg wrote:
>
>> I think we said we were waiting until stable pushed at 100% (today?), but
>> otherwise lgtm.
>>
>
> I didn't think there was much value in waiting, since we've already been
> at 30%
> for a bit and if we were to somehow switch back to non-aura, trunk
> wouldn't be
> what we'd use. I checked with cpu and he agreed.
>
> https://codereview.chromium.org/137403005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698