Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1374023002: Move JS support code from //mojo/edk/js to //services/js/system (Closed)

Created:
5 years, 2 months ago by jamesr
Modified:
5 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Move JS support code from //mojo/edk/js to //services/js/system This code lived in //mojo/edk/js to facilitate sharing it with chromium but since that's no longer a consideration for //mojo/edk this moves it to live with its only dependency //services/js (the JS content runner). This makes //mojo/edk's dependencies much clearer. R=hansmuller@chromium.org, vtl@google.com Committed: https://chromium.googlesource.com/external/mojo/+/1572dd5566c5fa460e22bdaa1d50cefb33f98480

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -2866 lines) Patch
M mojo/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
D mojo/edk/js/BUILD.gn View 1 chunk +0 lines, -68 lines 0 comments Download
D mojo/edk/js/core.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/edk/js/core.cc View 1 chunk +0 lines, -379 lines 0 comments Download
D mojo/edk/js/drain_data.h View 1 chunk +0 lines, -64 lines 0 comments Download
D mojo/edk/js/drain_data.cc View 1 chunk +0 lines, -131 lines 0 comments Download
D mojo/edk/js/handle.h View 1 chunk +0 lines, -98 lines 0 comments Download
D mojo/edk/js/handle.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D mojo/edk/js/handle_close_observer.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/edk/js/handle_unittest.cc View 1 chunk +0 lines, -90 lines 0 comments Download
D mojo/edk/js/mojo_runner_delegate.h View 1 chunk +0 lines, -33 lines 0 comments Download
D mojo/edk/js/mojo_runner_delegate.cc View 1 chunk +0 lines, -78 lines 0 comments Download
D mojo/edk/js/support.h View 1 chunk +0 lines, -22 lines 0 comments Download
D mojo/edk/js/support.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D mojo/edk/js/test/BUILD.gn View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/edk/js/test/hexdump.js View 1 chunk +0 lines, -34 lines 0 comments Download
D mojo/edk/js/test/run_js_integration_tests.cc View 1 chunk +0 lines, -57 lines 0 comments Download
D mojo/edk/js/test/run_js_tests.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D mojo/edk/js/tests/BUILD.gn View 1 chunk +0 lines, -37 lines 0 comments Download
D mojo/edk/js/tests/connection_tests.js View 1 chunk +0 lines, -240 lines 0 comments Download
D mojo/edk/js/tests/js_to_cpp.mojom View 1 chunk +0 lines, -54 lines 0 comments Download
D mojo/edk/js/tests/js_to_cpp_tests.cc View 1 chunk +0 lines, -426 lines 0 comments Download
D mojo/edk/js/tests/js_to_cpp_tests.js View 1 chunk +0 lines, -228 lines 0 comments Download
D mojo/edk/js/tests/sample_service_tests.js View 1 chunk +0 lines, -171 lines 0 comments Download
D mojo/edk/js/threading.h View 1 chunk +0 lines, -25 lines 0 comments Download
D mojo/edk/js/threading.cc View 1 chunk +0 lines, -47 lines 0 comments Download
D mojo/edk/js/waiting_callback.h View 1 chunk +0 lines, -68 lines 0 comments Download
D mojo/edk/js/waiting_callback.cc View 1 chunk +0 lines, -115 lines 0 comments Download
M services/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M services/js/BUILD.gn View 5 chunks +12 lines, -2 lines 0 comments Download
M services/js/js_app.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M services/js/js_app_runner_delegate.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M services/js/modules/clock/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/js/modules/clock/test/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/js/modules/clock/test/run_clock_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M services/js/modules/gl/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M services/js/modules/gl/context.h View 1 chunk +1 line, -1 line 0 comments Download
M services/js/modules/gl/module.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/js/system/BUILD.gn View 3 chunks +7 lines, -16 lines 0 comments Download
A + services/js/system/core.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/js/system/core.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/js/system/drain_data.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/js/system/drain_data.cc View 1 chunk +1 line, -1 line 0 comments Download
A + services/js/system/handle.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/js/system/handle.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/js/system/handle_close_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/js/system/handle_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/js/system/mojo_runner_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/js/system/mojo_runner_delegate.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + services/js/system/support.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/js/system/support.cc View 2 chunks +3 lines, -3 lines 0 comments Download
A services/js/system/test/BUILD.gn View 1 chunk +44 lines, -0 lines 0 comments Download
A + services/js/system/test/hexdump.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/js/system/test/run_js_integration_tests.cc View 2 chunks +5 lines, -5 lines 0 comments Download
A + services/js/system/test/run_js_tests.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/js/system/tests/BUILD.gn View 1 chunk +14 lines, -5 lines 0 comments Download
A + services/js/system/tests/connection_tests.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/js/system/tests/js_to_cpp.mojom View 0 chunks +-1 lines, --1 lines 0 comments Download
A + services/js/system/tests/js_to_cpp_tests.cc View 2 chunks +6 lines, -6 lines 0 comments Download
A + services/js/system/tests/js_to_cpp_tests.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/js/system/tests/sample_service_tests.js View 1 chunk +1 line, -1 line 0 comments Download
A + services/js/system/threading.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + services/js/system/threading.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + services/js/system/waiting_callback.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + services/js/system/waiting_callback.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
jamesr
5 years, 2 months ago (2015-09-28 20:41:26 UTC) #2
vtl
rs lgtm
5 years, 2 months ago (2015-09-28 21:02:30 UTC) #4
hansmuller
On 2015/09/28 20:41:26, jamesr wrote: Oh, but anyway, Toto, we're home. Home! LGTM
5 years, 2 months ago (2015-09-28 21:07:10 UTC) #5
jamesr
5 years, 2 months ago (2015-09-28 21:17:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
1572dd5566c5fa460e22bdaa1d50cefb33f98480 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698