Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 1373993002: Revert of ipc: Change the timing of the construction of the attachment broker. (Closed)

Created:
5 years, 2 months ago by erikchen
Modified:
5 years, 2 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ipc: Change the timing of the construction of the attachment broker. (patchset #3 id:40001 of https://codereview.chromium.org/1367013003/ ) Reason for revert: Still causes problems in at least one Dr. Memory test. https://code.google.com/p/chromium/issues/detail?id=536891 Requires further investigation - Reverting for now Original issue's description: > ipc: Change the timing of the construction of the attachment broker. > > This CL ensures that the privileged attachment broker is constructed earlier in > the process of creating a child process. This fixes a race condition for single > process mode where the child thread's attachment broker would become the global > attachment broker. > > BUG=534539 > > Committed: https://crrev.com/8758b4bd5bd210552606fa39d084aef7e786abd1 > Cr-Commit-Position: refs/heads/master@{#350899} TBR=avi@chromium.org,tsepez@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=534539 Committed: https://crrev.com/33f19091a0fcd48e91c88abf39f2a8293e8b0fd1 Cr-Commit-Position: refs/heads/master@{#351128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -9 lines) Patch
M content/common/child_process_host_impl.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ipc/attachment_broker.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
erikchen
Created Revert of ipc: Change the timing of the construction of the attachment broker.
5 years, 2 months ago (2015-09-28 20:25:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373993002/1
5 years, 2 months ago (2015-09-28 20:25:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 20:27:17 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 20:28:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/33f19091a0fcd48e91c88abf39f2a8293e8b0fd1
Cr-Commit-Position: refs/heads/master@{#351128}

Powered by Google App Engine
This is Rietveld 408576698