Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(692)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1373983005: [Smart Lock, Settings Reconciliation] Histograms for tracking initial and final pref values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« chrome/browser/password_manager/password_manager_setting_migrator_service.cc ('K') | « chrome/browser/password_manager/password_manager_setting_migrator_service_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 045072efd97d7e12fa54cab2916616578f86a011..7663dacb7a2c3b6f200c4756ea3198247b3eb0df 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -30281,6 +30281,19 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="PasswordManager.SettingsReconciliation.InitialAndFinalValues"
+ enum="PasswordManagerPreferencesInitialAndFinalValues">
+ <owner>engedy@chromium.org</owner>
+ <owner>melandory@chromium.org</owner>
+ <summary>
+ Tracks the pair of initial values and pair of final values for the legacy
+ preference for controlling the Chrome Password Manager and the new
+ preference for controlling Smart Lock on Android. Sample is recorded after
engedy 2015/09/29 13:24:52 nit: A single sample ...
melandory 2015/09/29 22:08:38 Done.
+ sync has merged last snaphot and finished initialization for the sync users
engedy 2015/09/29 13:24:53 nit: for sync users, and on profile initialization
melandory 2015/09/29 22:08:38 Done.
+ or on the profile initialization for non sync users.
+ </summary>
+</histogram>
+
<histogram name="PasswordManager.SettingsReconciliation.InitialValues"
enum="PasswordManagerPreferencesInitialValues">
<owner>engedy@chromium.org</owner>
@@ -66995,6 +67008,62 @@ To add a new entry, add it with any value and run test to compute valid value.
label="Password status not checked as user is on a Windows Domain"/>
</enum>
+<enum name="PasswordManagerPreferencesInitialAndFinalValues" type="int">
+ <summary>
+ The pair initial values and the pair of final values for the legacy
+ preference for controlling the Chrome Password Manager and new preference
+ for controlling Smart Lock on Android.
+ </summary>
+ <int value="0"
+ label="Initial state: new pref is 'off', legacy pref is 'off' Final
engedy 2015/09/29 13:24:53 nit: These strings are very long and will probably
melandory 2015/09/29 22:08:38 Done.
+ state: new pref is 'off', legacy pref is 'off'"/>
+ <int value="1"
+ label="Initial state: new pref is 'off', legacy pref is 'off' Final
+ state: new pref is 'off', legacy pref is 'on'"/>
+ <int value="2"
+ label="Initial state: new pref is 'off', legacy pref is 'off' Final
+ state: new pref is 'on', legacy pref is 'off'"/>
+ <int value="3"
+ label="Initial state: new pref is 'off', legacy pref is 'off' Final
+ state: new pref is 'on', legacy pref is 'on'"/>
+ <int value="4"
+ label="Initial state: new pref is 'off', legacy pref is 'on' Final
+ state: new pref is 'off', legacy pref is 'off'"/>
+ <int value="5"
+ label="Initial state: new pref is 'off', legacy pref is 'on' Final
+ state: new pref is 'off', legacy pref is 'on'"/>
+ <int value="6"
+ label="Initial state: new pref is 'off', legacy pref is 'on' Final
+ state: new pref is 'on', legacy pref is 'off'"/>
+ <int value="7"
+ label="Initial state: new pref is 'off', legacy pref is 'on' Final
+ state: new pref is 'on', legacy pref is 'on'"/>
+ <int value="8"
+ label="Initial state: new pref is 'on', legacy pref is 'off' Final
+ state: new pref is 'off', legacy pref is 'off'"/>
+ <int value="9"
+ label="Initial state: new pref is 'on', legacy pref is 'off' Final
+ state: new pref is 'off', legacy pref is 'on'"/>
+ <int value="10"
+ label="Initial state: new pref is 'on', legacy pref is 'off' Final
+ state: new pref is 'on', legacy pref is 'off'"/>
+ <int value="11"
+ label="Initial state: new pref is 'on', legacy pref is 'off' Final
+ state: new pref is 'on', legacy pref is 'on'"/>
+ <int value="12"
+ label="Initial state: new pref is 'on', legacy pref is 'on' Final
+ state: new pref is 'off', legacy pref is 'off'"/>
+ <int value="13"
+ label="Initial state: new pref is 'on', legacy pref is 'on' Final
+ state: new pref is 'off', legacy pref is 'on'"/>
+ <int value="14"
+ label="Initial state: new pref is 'on', legacy pref is 'on' Final
+ state: new pref is 'on', legacy pref is 'off'"/>
+ <int value="15"
+ label="Initial state: new pref is 'on', legacy pref is 'on' Final
+ state: new pref is 'on', legacy pref is 'on'"/>
+</enum>
+
<enum name="PasswordManagerPreferencesInitialValues" type="int">
<summary>
The pair of initial values for the legacy preference for controlling the
« chrome/browser/password_manager/password_manager_setting_migrator_service.cc ('K') | « chrome/browser/password_manager/password_manager_setting_migrator_service_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698