chrome/android/BUILD.gn - Issue 1373983003: Add UMA stats for which icon types are shown and clicked on the NTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/BUILD.gn

Issue 1373983003: Add UMA stats for which icon types are shown and clicked on the NTP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/ntp/MostVisitedItem.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/BUILD.gn

diff --git a/chrome/android/BUILD.gn b/chrome/android/BUILD.gn

index de63d75a751af5fef7d6d0ec7a35a3f278cb2d3c..c61e317e73825d7760deb0efdce225fb4ab9a46c 100644

--- a/chrome/android/BUILD.gn

+++ b/chrome/android/BUILD.gn

@@ -185,6 +185,7 @@ java_cpp_enum("chrome_android_java_enums_srcjar") {

sources = [

"//chrome/browser/android/activity_type_ids.h",

"//chrome/browser/android/feedback/connectivity_checker.cc",

+ "//chrome/browser/android/most_visited_sites.cc",

"//chrome/browser/android/shortcut_info.h",

"//chrome/browser/android/tab_android.h",

"//chrome/browser/profiles/profile_metrics.h",

@@ -194,6 +195,7 @@ java_cpp_enum("chrome_android_java_enums_srcjar") {

outputs = [

"org/chromium/chrome/browser/ActivityTypeIds.java",

"org/chromium/chrome/browser/feedback/ConnectivityCheckResult.java",

+ "org/chromium/chrome/browser/ntp/MostVisitedTileType.java",

"org/chromium/chrome/browser/ShortcutSource.java",

"org/chromium/chrome/browser/TabLoadStatus.java",

"org/chromium/chrome/browser/profiles/ProfileAccountManagementMetrics.java",