chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java - Issue 1373983003: Add UMA stats for which icon types are shown and clicked on the NTP.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java

Issue 1373983003: Add UMA stats for which icon types are shown and clicked on the NTP. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fixed test Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java ('k') | chrome/browser/android/most_visited_sites.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java

index f4674307bbd8160e6dbf6810ef9982c58cf453c1..d97a21e97408609b394fc541baf94ea11de8147d 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/FakeMostVisitedSites.java

@@ -49,7 +49,7 @@ public class FakeMostVisitedSites extends MostVisitedSites {

ThreadUtils.postOnUiThread(new Runnable() {

@Override

public void run() {

- callback.onMostVisitedURLsThumbnailAvailable(null);

+ callback.onMostVisitedURLsThumbnailAvailable(null, true);

}

});

}

@@ -67,7 +67,12 @@ public class FakeMostVisitedSites extends MostVisitedSites {

}

@Override

- public void recordOpenedMostVisitedItem(int index) {

+ public void recordTileTypeMetrics(int[] tileTypes, boolean isIconMode) {

+ // Metrics are stubbed out.

+ }

+ @Override

+ public void recordOpenedMostVisitedItem(int index, int tileType) {

// Metrics are stubbed out.

}