linux_aura: Port the linux first run dialog to aura.

chrome/browser/ui/views/first_run_dialog.cc

Index: chrome/browser/ui/views/first_run_dialog.cc
diff --git a/chrome/browser/ui/views/first_run_dialog.cc b/chrome/browser/ui/views/first_run_dialog.cc
new file mode 100644
index 0000000000000000000000000000000000000000..45e6cd4765765e5edb2280401406d456aea7f252
--- /dev/null
+++ b/chrome/browser/ui/views/first_run_dialog.cc
@@ -0,0 +1,152 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/first_run_dialog.h"
+
+#include "chrome/browser/first_run/first_run.h"
+#include "chrome/browser/platform_util.h"
+#include "chrome/browser/shell_integration.h"
+#include "chrome/browser/ui/views/constrained_window_views.h"
+#include "chrome/common/url_constants.h"
+#include "chrome/installer/util/google_update_settings.h"
+#include "components/breakpad/app/breakpad_linux.h"
+#include "grit/chromium_strings.h"
+#include "grit/generated_resources.h"
+#include "grit/locale_settings.h"
+#include "grit/theme_resources.h"
+#include "ui/aura/client/dispatcher_client.h"
+#include "ui/aura/env.h"
+#include "ui/aura/root_window.h"
+#include "ui/base/l10n/l10n_util.h"
+#include "ui/views/controls/button/checkbox.h"
+#include "ui/views/controls/link.h"
+#include "ui/views/layout/grid_layout.h"
+#include "ui/views/layout/layout_constants.h"
+#include "ui/views/widget/widget.h"
+#include "ui/views/window/dialog_delegate.h"
+
+#if defined(GOOGLE_CHROME_BUILD)
+#include "base/prefs/pref_service.h"
+#include "chrome/browser/browser_process.h"
+#endif
+
+using views::GridLayout;
+
+namespace first_run {
+
+bool ShowFirstRunDialog(Profile* profile) {
+  return FirstRunDialog::Show(profile);
+}
+
+}  // namespace first_run
+
+// static
+bool FirstRunDialog::Show(Profile* profile) {
+  bool dialog_shown = false;
+
+#if defined(GOOGLE_CHROME_BUILD)
+  // If the metrics reporting is managed, we won't ask.
+  const PrefService::Preference* metrics_reporting_pref =
+      g_browser_process->local_state()->FindPreference(
+          prefs::kMetricsReportingEnabled);
+  bool show_reporting_dialog = !metrics_reporting_pref ||

[msw, 2014/01/15 20:22:41]

nit: this could be inlined

+      !metrics_reporting_pref->IsManaged();
+
+  if (show_reporting_dialog) {
+    FirstRunDialog* dialog = new FirstRunDialog(profile);
+    CreateBrowserModalDialogViews(dialog, NULL)->Show();

[msw, 2014/01/15 20:22:41]

Will this show over an actual running browser window? If so, can you try to find
it for parenting here? Otherwise, this should probably use
DialogDelegate::CreateDialogWidget (and supply a context if one is available).

[Elliot Glaysher, 2014/01/15 20:41:31]

I previously did that and had some focus issues. I copied this because its used
in simple_message_box_views.cc, which we also use in an early pre-Browser world
to show the root error dialog.

[msw, 2014/01/15 20:59:37]

Hmm, then doesn't this just equate to DialogDelegate::CreateDialogWidget(dialog,
NULL, NULL)? I would avoid using CreateBrowserModalDialogViews for a dialog that
is not browser modal; you can also then remove the constrained_window_views.h
include.

[Elliot Glaysher, 2014/01/15 22:01:39]

Tested again. Worked this time. Done.

+
+    // Use the widget's window itself so that the message loop
+    // exists when the dialog is closed by some other means than
+    // |Accept|.
+    //
+    // This is the same trick used in simple_message_box_views.cc, minus the
+    // refcounting.
+    aura::Window* anchor = dialog->GetWidget()->GetNativeWindow();
+    aura::client::DispatcherClient* client =
+        aura::client::GetDispatcherClient(anchor->GetRootWindow());
+    client->RunWithDispatcher(dialog, anchor, true);
+    dialog_shown = true;
+  }
+#endif  // defined(GOOGLE_CHROME_BUILD)
+
+  return dialog_shown;
+}
+
+FirstRunDialog::FirstRunDialog(Profile* profile)
+    : profile_(profile),
+      make_default_(NULL),
+      report_crashes_(NULL),
+      should_show_dialog_(true) {
+  Init();
+}
+
+FirstRunDialog::~FirstRunDialog() {
+}
+
+void FirstRunDialog::Init() {

[msw, 2014/01/15 20:22:41]

nit: this could be inlined to the ctor

+  GridLayout* layout = GridLayout::CreatePanel(this);
+  SetLayoutManager(layout);
+
+  const int related_y = views::kRelatedControlVerticalSpacing;
+
+  views::ColumnSet* column_set = layout->AddColumnSet(0);
+  column_set->AddColumn(GridLayout::FILL, GridLayout::CENTER, 0,
+                        GridLayout::USE_PREF, 0, 0);
+
+  layout->StartRow(0, 0);
+  make_default_ = new views::Checkbox(l10n_util::GetStringUTF16(
+      IDS_FR_CUSTOMIZE_DEFAULT_BROWSER));
+  make_default_->SetChecked(true);
+  layout->AddView(make_default_);
+
+  layout->StartRowWithPadding(0, 0, 0, related_y);
+  report_crashes_ = new views::Checkbox(l10n_util::GetStringUTF16(
+      IDS_OPTIONS_ENABLE_LOGGING));
+  layout->AddView(report_crashes_);
+
+  // layout->StartRowWithPadding(0, 0, 0, related_y);

[msw, 2014/01/15 20:22:41]

nit: remove commented code.

+  // layout->AddView(link);
+}
+
+views::View* FirstRunDialog::CreateExtraView() {
+  views::Link* link = new views::Link(l10n_util::GetStringUTF16(
+      IDS_LEARN_MORE));
+  link->set_listener(this);
+  return link;
+}
+
+void FirstRunDialog::OnClosed() {

[msw, 2014/01/15 20:22:41]

Should this also set should_show_dialog_ to false?

+  first_run::SetShouldShowWelcomePage();
+}
+
+bool FirstRunDialog::Accept() {
+  should_show_dialog_= false;

[msw, 2014/01/15 20:22:41]

nit: add a space before '='.

+  GetWidget()->Hide();
+
+  if (report_crashes_ && report_crashes_->checked()) {
+    if (GoogleUpdateSettings::SetCollectStatsConsent(true))
+      breakpad::InitCrashReporter(std::string());
+  } else {
+    GoogleUpdateSettings::SetCollectStatsConsent(false);
+  }
+
+  if (make_default_ && make_default_->checked())
+    ShellIntegration::SetAsDefaultBrowser();
+
+  return true;
+}
+
+int FirstRunDialog::GetDialogButtons() const {
+  return ui::DIALOG_BUTTON_OK;
+}
+
+void FirstRunDialog::LinkClicked(views::Link* source, int event_flags) {
+  platform_util::OpenExternal(profile_, GURL(chrome::kLearnMoreReportingURL));
+}
+
+bool FirstRunDialog::Dispatch(const base::NativeEvent& event) {
+  aura::Env::GetInstance()->GetDispatcher()->Dispatch(event);
+  return should_show_dialog_;
+}