Issue 1373923004: Move gn goma setup to gcc_toolchain

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1373923004: Move gn goma setup to gcc_toolchain (Closed)

Created:
5 years, 2 months ago by Petr Hosek

Modified:
5 years, 2 months ago

Reviewers:
jamesr

CC:
mojo-reviews_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -38 lines)			Patch
M	build/toolchain/android/BUILD.gn	View		2 chunks	+4 lines, -15 lines	0 comments	Download
M	build/toolchain/cros/BUILD.gn	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	build/toolchain/fnl/BUILD.gn	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	build/toolchain/gcc_toolchain.gni	View	1	3 chunks	+19 lines, -2 lines	0 comments	Download
M	build/toolchain/linux/BUILD.gn	View	1	6 chunks	+12 lines, -21 lines	0 comments	Download

Total messages: 6 (1 generated)

jamesr

lgtm as far as I can see but let's see what the trybots think too...

5 years, 2 months ago (2015-09-28 22:17:29 UTC) #1

Petr Hosek

On 2015/09/28 23:49:19, jamesr wrote: > Seems happier? Yeah, now it seems fine, shall I ...

5 years, 2 months ago (2015-09-29 00:57:51 UTC) #4

jamesr

On 2015/09/29 at 00:57:51, phosek wrote: > On 2015/09/28 23:49:19, jamesr wrote: > > Seems ...

5 years, 2 months ago (2015-09-29 01:24:42 UTC) #5

Petr Hosek

5 years, 2 months ago (2015-09-29 01:26:23 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:40001) manually as
a392b30116f6b8ff27eff4eea3ff51e120c35692 (presubmit successful).