Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1373923003: HID report descriptors not available before OS X 10.8. (Closed)

Created:
5 years, 2 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 2 months ago
Reviewers:
juncai
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

HID report descriptors not available before OS X 10.8. On OS X Snow Leopard and Lion (currently supported by Chrome) the kIOHIDReportDescriptorKey is not available as it is in later versions of the operating system. Since we are also unable to get the device's report descriptor on Windows it seems okay to just ignore the failure. BUG=479210 Committed: https://crrev.com/7015dfbf9a232ef20022454986d3bd251b12b824 Cr-Commit-Position: refs/heads/master@{#351183}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M device/hid/hid_service_mac.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 2 months ago (2015-09-28 21:48:02 UTC) #2
juncai
lgtm
5 years, 2 months ago (2015-09-28 21:55:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373923003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373923003/1
5 years, 2 months ago (2015-09-28 21:57:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 22:45:20 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 22:46:57 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7015dfbf9a232ef20022454986d3bd251b12b824
Cr-Commit-Position: refs/heads/master@{#351183}

Powered by Google App Engine
This is Rietveld 408576698