Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 1373923002: Add ui_account_tweaks.html (Closed)

Created:
5 years, 2 months ago by michaelpg
Modified:
5 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ui_account_tweaks.html Like the Options page, the Languages section of MD Settings, among others, will need access to information about the CrOS user for enabling, disabling and decorating controls. We prefer using HTML imports (e.g. cr.html), ergo, this CL. BUG=512497 R=dbeam@chromium.org Committed: https://crrev.com/0f66630b1c74a307aff476272f3480980b7e4735 Cr-Commit-Position: refs/heads/master@{#351138}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
A ui/webui/resources/html/chromeos/ui_account_tweaks.html View 1 chunk +1 line, -0 lines 0 comments Download
M ui/webui/resources/webui_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
michaelpg
5 years, 2 months ago (2015-09-28 17:34:16 UTC) #1
Dan Beam
why?
5 years, 2 months ago (2015-09-28 17:46:26 UTC) #2
michaelpg
On 2015/09/28 17:46:26, Dan Beam wrote: > why? fair point, added to description (who would've ...
5 years, 2 months ago (2015-09-28 18:27:47 UTC) #3
Dan Beam
lgtm
5 years, 2 months ago (2015-09-28 18:30:10 UTC) #4
Dan Beam
please add a BUG=, though
5 years, 2 months ago (2015-09-28 18:30:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373923002/1
5 years, 2 months ago (2015-09-28 18:57:48 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 20:55:35 UTC) #8
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 20:57:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f66630b1c74a307aff476272f3480980b7e4735
Cr-Commit-Position: refs/heads/master@{#351138}

Powered by Google App Engine
This is Rietveld 408576698