GN: Schedule config loads for sub-configs.

GN: Schedule config loads for sub-configs.

Previously the Builder did not schedule file loads for configs of configs.

This meant that if a BUILD file contained only configs referenced by other
configs (rather than configs referenced by targets, or targets referenced by
other targets), it would never be loaded. The result will be a failed run with
an undefined object.

BUG=536844
Committed: https://crrev.com/1b1e7e8c8f3105b6c9811ff28947961eb96153c3
Cr-Commit-Position: refs/heads/master@{#351089}

[brettw, 2015-09-28 16:36:07]

brettw@chromium.org changed reviewers:
+ andybons@chromium.org

[brettw, 2015-09-28 16:36:10]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-28 16:37:26]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1373903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1373903002/1

[Bons, 2015-09-28 16:39:45]

lgtm

https://codereview.chromium.org/1373903002/diff/1/tools/gn/builder.cc
File tools/gn/builder.cc (right):

https://codereview.chromium.org/1373903002/diff/1/tools/gn/builder.cc#newcode245
tools/gn/builder.cc:245: // item types like targets, the "should generate" flag
is propogated around
propagated

https://codereview.chromium.org/1373903002/diff/1/tools/gn/builder_unittest.cc
File tools/gn/builder_unittest.cc (right):

https://codereview.chromium.org/1373903002/diff/1/tools/gn/builder_unittest.c...
tools/gn/builder_unittest.cc:40: files_.clear();
in which i wish we had go's defer :)

https://codereview.chromium.org/1373903002/diff/1/tools/gn/builder_unittest.c...
tools/gn/builder_unittest.cc:46: }
newline after this?

[commit-bot: I haz the power, 2015-09-28 16:52:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 16:52:43]

Dry run: This issue passed the CQ dry run.

[brettw, 2015-09-28 17:00:02]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-09-28 17:00:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1373903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1373903002/1

[commit-bot: I haz the power, 2015-09-28 17:06:25]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-28 17:07:02]

Patchset 1 (id:??) landed as
https://crrev.com/1b1e7e8c8f3105b6c9811ff28947961eb96153c3
Cr-Commit-Position: refs/heads/master@{#351089}

[Bons, 2015-09-28 17:11:43]

https://codereview.chromium.org/1373903002/diff/1/tools/gn/builder.cc
File tools/gn/builder.cc (right):

https://codereview.chromium.org/1373903002/diff/1/tools/gn/builder.cc#newcode245
tools/gn/builder.cc:245: // item types like targets, the "should generate" flag
is propogated around
On 2015/09/28 16:39:45, Bons wrote:
> propagated

what about this?

[brettw, 2015-09-28 19:47:46]

Sorry, will fix

[brettw, 2015-09-28 19:49:20]

https://codereview.chromium.org/1373903002/diff/1/tools/gn/builder_unittest.cc
File tools/gn/builder_unittest.cc (right):

https://codereview.chromium.org/1373903002/diff/1/tools/gn/builder_unittest.c...
tools/gn/builder_unittest.cc:46: }
On 2015/09/28 16:39:45, Bons wrote:
> newline after this?

I wanted to group these together since the comment above really applies to both.

[Bons, 2015-09-28 20:03:53]

On 2015/09/28 19:49:20, brettw wrote:
> https://codereview.chromium.org/1373903002/diff/1/tools/gn/builder_unittest.cc
> File tools/gn/builder_unittest.cc (right):
> 
>
https://codereview.chromium.org/1373903002/diff/1/tools/gn/builder_unittest.c...
> tools/gn/builder_unittest.cc:46: }
> On 2015/09/28 16:39:45, Bons wrote:
> > newline after this?
> 
> I wanted to group these together since the comment above really applies to
both.
Got it. Sounds good.