Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issue 1373853003: Don't choose a background process when choosing a process for starting a Service Worker. (Closed)

Created:
5 years, 2 months ago by horo
Modified:
5 years, 2 months ago
Reviewers:
kinuko
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, serviceworker-reviews, creis+watch_chromium.org, tzik, nasko+codewatch_chromium.org, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+serviceworker, kinuko+watch, blink-worker-reviews_chromium.org, Yaron
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't choose a background process when choosing a process for starting a Service Worker. This is a quick fix for https://crbug.com/531345. We need to revisit the behavior of ServiceWorker and the timer suspension of background processes which was intoruced by https://codereview.chromium.org/1133143003. BUG=531345 Committed: https://crrev.com/3ddd919b0f5550377e178ba6d4aa5256701d53ff Cr-Commit-Position: refs/heads/master@{#351530}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_process_manager.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
horo
kinuko@ Could you please review this?
5 years, 2 months ago (2015-09-30 08:45:28 UTC) #2
kinuko
Thanks for making this... Were you able to test the actual behavior? https://codereview.chromium.org/1373853003/diff/1/content/browser/service_worker/service_worker_process_manager.cc File content/browser/service_worker/service_worker_process_manager.cc ...
5 years, 2 months ago (2015-09-30 09:26:15 UTC) #3
horo
> Were you able to test the actual behavior? Yes. Done manually. https://codereview.chromium.org/1373853003/diff/1/content/browser/service_worker/service_worker_process_manager.cc File content/browser/service_worker/service_worker_process_manager.cc ...
5 years, 2 months ago (2015-09-30 09:45:37 UTC) #4
kinuko
lgtm. lgtm
5 years, 2 months ago (2015-09-30 09:53:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373853003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373853003/20001
5 years, 2 months ago (2015-09-30 10:09:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 11:04:38 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3ddd919b0f5550377e178ba6d4aa5256701d53ff Cr-Commit-Position: refs/heads/master@{#351530}
5 years, 2 months ago (2015-09-30 11:05:27 UTC) #9
horo
5 years, 2 months ago (2015-10-01 03:43:43 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1380023002/ by horo@chromium.org.

The reason for reverting is: - This patch will increase memory pressure to
launch a new SW process.
- More reasonable patch (crrev.com/351714) landed..

Powered by Google App Engine
This is Rietveld 408576698