Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1373843004: Added PPAPI win32k lockdown options to chrome://flags. (Closed)

Created:
5 years, 2 months ago by forshaw
Modified:
5 years, 2 months ago
Reviewers:
Ilya Sherman, jam
CC:
chromium-reviews, darin-cc_chromium.org, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added PPAPI win32k lockdown options to chrome://flags. This patch adds the PPAPI win32k lockdown command line to the flags page along with necessary changes to ensure tests work correctly. BUG=523278 Committed: https://crrev.com/9745511be6490f393f829aa8acb85e66aba26cb9 Cr-Commit-Position: refs/heads/master@{#351542}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed actions.xml patch. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 chunks +26 lines, -0 lines 0 comments Download
M content/common/content_switches_internal.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
forshaw
isherman@chromium.org: Can you please review changes in the metrics component. jam@chromium.org: Can you please review ...
5 years, 2 months ago (2015-09-29 12:58:24 UTC) #2
jam
On 2015/09/29 12:58:24, forshaw wrote: > mailto:isherman@chromium.org: Can you please review changes in the metrics ...
5 years, 2 months ago (2015-09-29 19:43:16 UTC) #3
forshaw
On 2015/09/29 19:43:16, jam wrote: > On 2015/09/29 12:58:24, forshaw wrote: > > mailto:isherman@chromium.org: Can ...
5 years, 2 months ago (2015-09-29 19:44:05 UTC) #4
Ilya Sherman
https://codereview.chromium.org/1373843004/diff/1/tools/metrics/actions/actions.xml File tools/metrics/actions/actions.xml (right): https://codereview.chromium.org/1373843004/diff/1/tools/metrics/actions/actions.xml#newcode186 tools/metrics/actions/actions.xml:186: </action> Hmm, I don't remember: Is this entry automatically ...
5 years, 2 months ago (2015-09-30 04:13:37 UTC) #5
forshaw
On 2015/09/30 04:13:37, Ilya Sherman wrote: > https://codereview.chromium.org/1373843004/diff/1/tools/metrics/actions/actions.xml > File tools/metrics/actions/actions.xml (right): > > https://codereview.chromium.org/1373843004/diff/1/tools/metrics/actions/actions.xml#newcode186 ...
5 years, 2 months ago (2015-09-30 10:11:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373843004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373843004/20001
5 years, 2 months ago (2015-09-30 12:22:57 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-30 13:29:07 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 13:29:57 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9745511be6490f393f829aa8acb85e66aba26cb9
Cr-Commit-Position: refs/heads/master@{#351542}

Powered by Google App Engine
This is Rietveld 408576698